Skip to content

Fix lint errors #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Fix lint errors #4488

merged 2 commits into from
Feb 18, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2021

⚠️ No Changeset found

Latest commit: ecc9814

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 18, 2021

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (ee6980d) Head (e5bcb56) Diff
    browser 278 kB 277 kB -767 B (-0.3%)
    esm2017 246 kB 245 kB -421 B (-0.2%)
    main 280 kB 280 kB -767 B (-0.3%)
    module 278 kB 277 kB -767 B (-0.3%)
  • @firebase/database-exp

    Type Base (ee6980d) Head (e5bcb56) Diff
    browser 278 kB 278 kB -767 B (-0.3%)
    esm2017 243 kB 243 kB -421 B (-0.2%)
    main 280 kB 279 kB -767 B (-0.3%)
    module 278 kB 278 kB -767 B (-0.3%)
  • firebase

    Type Base (ee6980d) Head (e5bcb56) Diff
    firebase-database.js 191 kB 189 kB -1.52 kB (-0.8%)
    firebase.js 852 kB 851 kB -1.52 kB (-0.2%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 18, 2021

Size Analysis Report

Affected Products

No changes between base commit (ee6980d) and head commit (e5bcb56).

@Feiyang1 Feiyang1 merged commit 483567a into master Feb 18, 2021
@Feiyang1 Feiyang1 deleted the fei-fix-lint branch February 18, 2021 22:23
@firebase firebase locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants