Tree-shake RepoInfo #4515
Merged
Tree-shake RepoInfo #4515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
requested review from
Feiyang1,
hiranya911,
jsdt and
schmidt-sebastian
as code owners
Binary Size ReportAffected SDKs
Test Logs
|
Size Analysis Report |
schmidt-sebastian
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
I think it is pretty hard to determine which methods actually make a difference in terms of bundle size until we have the API implemented. I think your change makes sense. If there is anything that stands out once we have a tree-shakeable API we can always change it.
| @@ -133,3 +91,51 @@ export class RepoInfo { | |||
| return `${protocol}${this.host}/${query}`; | |||
| } | |||
| } | |||
|
|
|||
| function needsQueryParam(repoInfo: RepoInfo): boolean { | |||
There was a problem hiding this comment.
Nit: I would also prefix this with "repoInfo" for consistency.
Feiyang1
approved these changes
Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like most of the methods should stay on the class, I only extracted
connectionURLand its helper methodneedsQueryParambut let me know if that's incorrect.