Skip to content

[Auth] Fix compat demo which was missing index.html file #5561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2021
Merged

[Auth] Fix compat demo which was missing index.html file #5561

merged 2 commits into from
Sep 30, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Sep 30, 2021

The .gitignore for the compat demo erroneously included an index.* rule.

@sam-gc sam-gc requested a review from yuchenshi September 30, 2021 16:00
@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2021

⚠️ No Changeset found

Latest commit: 9069ade

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Sep 30, 2021
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (aa48acc) and head commit (9065899).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (aa48acc) and head commit (9065899).

@sam-gc sam-gc merged commit 91117e0 into master Sep 30, 2021
@sam-gc sam-gc deleted the sam-gc/demo branch September 30, 2021 16:56
@firebase firebase locked and limited conversation to collaborators Oct 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lisajian lisajian lisajian approved these changes

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@lisajian lisajian

@yuchenshi yuchenshi

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sam-gc @google-oss-bot @lisajian @yuchenshi