Skip to content

Fix canary/prerelease to publish compat packages #5583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Oct 6, 2021

After new packages were added (compat, messaging-interop-types, api-documenter), we did not add wombat-dressing-room keys.

Not sure if it's necessary to publish api-documenter with canary but the workflow will appear as a failure if one package publish fails, so it's either that or exclude it in the prerelease script.

Secrets have already been added to the repo.

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2021

⚠️ No Changeset found

Latest commit: 4896a9b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 6, 2021
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (e456d00) and head commit (979ddad).

Test Logs

@hsubox76 hsubox76 merged commit b9235c6 into master Oct 6, 2021
@hsubox76 hsubox76 deleted the ch-canary-test branch October 6, 2021 17:38
@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (e456d00) and head commit (979ddad).

@firebase firebase locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants