-
Notifications
You must be signed in to change notification settings - Fork 938
VinF Hybrid Inference #3: Implement ChromeAdapter #8917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
erikeldridge
wants to merge
11
commits into
erikeldridge-vertex-adapter
from
erikeldridge-vertex-adapterimpl
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
25c6397
Implement ChromeAdapter class
erikeldridge 15d114c
Integrate with e2e test app
erikeldridge 8f15d63
Merge branch 'erikeldridge-vertex-adapter' into erikeldridge-vertex-a…
erikeldridge 3f02db0
Run yarn format
erikeldridge ee4d3aa
Test model download logic
erikeldridge d546aec
Test request-based availability checks
erikeldridge 87fbb9b
Test content generation
erikeldridge 29d399f
Remove request.systemInstruction validation
erikeldridge 1b7233d
Refactor to emulate Vertex response
erikeldridge 4db0d63
Update content generator to emulate Vertex response
erikeldridge 5dfd435
Merge branch 'erikeldridge-vertex-adapter' into erikeldridge-vertex-a…
erikeldridge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,301 @@ | ||
/** | ||
* @license | ||
* Copyright 2025 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { expect, use } from 'chai'; | ||
import sinonChai from 'sinon-chai'; | ||
import chaiAsPromised from 'chai-as-promised'; | ||
import { ChromeAdapter } from './chrome-adapter'; | ||
import { stub } from 'sinon'; | ||
import * as util from '@firebase/util'; | ||
|
||
use(sinonChai); | ||
use(chaiAsPromised); | ||
|
||
describe('ChromeAdapter', () => { | ||
describe('isAvailable', () => { | ||
it('returns false if mode is only cloud', async () => { | ||
const adapter = new ChromeAdapter(undefined, 'only_in_cloud'); | ||
expect( | ||
await adapter.isAvailable({ | ||
contents: [] | ||
}) | ||
).to.be.false; | ||
}); | ||
it('returns false if browser is not Chrome', async () => { | ||
const chromeStub = stub(util, 'isChrome').returns(false); | ||
const adapter = new ChromeAdapter(undefined, 'prefer_on_device'); | ||
expect( | ||
await adapter.isAvailable({ | ||
contents: [] | ||
}) | ||
).to.be.false; | ||
chromeStub.restore(); | ||
}); | ||
it('returns false if AI API is undefined', async () => { | ||
const adapter = new ChromeAdapter(undefined, 'prefer_on_device'); | ||
expect( | ||
await adapter.isAvailable({ | ||
contents: [] | ||
}) | ||
).to.be.false; | ||
}); | ||
it('returns false if LanguageModel API is undefined', async () => { | ||
const adapter = new ChromeAdapter({} as AI, 'prefer_on_device'); | ||
expect( | ||
await adapter.isAvailable({ | ||
contents: [] | ||
}) | ||
).to.be.false; | ||
}); | ||
it('returns false if request contents empty', async () => { | ||
const adapter = new ChromeAdapter({} as AI, 'prefer_on_device'); | ||
expect( | ||
await adapter.isAvailable({ | ||
contents: [] | ||
}) | ||
).to.be.false; | ||
}); | ||
it('returns false if request content has function role', async () => { | ||
const adapter = new ChromeAdapter({} as AI, 'prefer_on_device'); | ||
expect( | ||
await adapter.isAvailable({ | ||
contents: [ | ||
{ | ||
role: 'function', | ||
parts: [] | ||
} | ||
] | ||
}) | ||
).to.be.false; | ||
}); | ||
it('returns false if request content has multiple parts', async () => { | ||
const adapter = new ChromeAdapter({} as AI, 'prefer_on_device'); | ||
expect( | ||
await adapter.isAvailable({ | ||
contents: [ | ||
{ | ||
role: 'user', | ||
parts: [{ text: 'a' }, { text: 'b' }] | ||
} | ||
] | ||
}) | ||
).to.be.false; | ||
}); | ||
it('returns false if request content has non-text part', async () => { | ||
const adapter = new ChromeAdapter({} as AI, 'prefer_on_device'); | ||
expect( | ||
await adapter.isAvailable({ | ||
contents: [ | ||
{ | ||
role: 'user', | ||
parts: [{ inlineData: { mimeType: 'a', data: 'b' } }] | ||
} | ||
] | ||
}) | ||
).to.be.false; | ||
}); | ||
it('returns true if model is readily available', async () => { | ||
const aiProvider = { | ||
languageModel: { | ||
capabilities: () => | ||
Promise.resolve({ | ||
available: 'readily' | ||
}) | ||
} | ||
} as AI; | ||
const adapter = new ChromeAdapter(aiProvider, 'prefer_on_device'); | ||
expect( | ||
await adapter.isAvailable({ | ||
contents: [{ role: 'user', parts: [{ text: 'hi' }] }] | ||
}) | ||
).to.be.true; | ||
}); | ||
it('returns false and triggers download when model is available after download', async () => { | ||
const aiProvider = { | ||
languageModel: { | ||
capabilities: () => | ||
Promise.resolve({ | ||
available: 'after-download' | ||
}), | ||
create: () => Promise.resolve({}) | ||
} | ||
} as AI; | ||
const createStub = stub(aiProvider.languageModel, 'create').resolves( | ||
{} as AILanguageModel | ||
); | ||
const onDeviceParams = {} as AILanguageModelCreateOptionsWithSystemPrompt; | ||
const adapter = new ChromeAdapter( | ||
aiProvider, | ||
'prefer_on_device', | ||
onDeviceParams | ||
); | ||
expect( | ||
await adapter.isAvailable({ | ||
contents: [{ role: 'user', parts: [{ text: 'hi' }] }] | ||
}) | ||
).to.be.false; | ||
expect(createStub).to.have.been.calledOnceWith(onDeviceParams); | ||
}); | ||
it('avoids redundant downloads', async () => { | ||
const aiProvider = { | ||
languageModel: { | ||
capabilities: () => | ||
Promise.resolve({ | ||
available: 'after-download' | ||
}), | ||
create: () => {} | ||
} | ||
} as AI; | ||
const downloadPromise = new Promise<AILanguageModel>(() => { | ||
/* never resolves */ | ||
}); | ||
const createStub = stub(aiProvider.languageModel, 'create').returns( | ||
downloadPromise | ||
); | ||
const adapter = new ChromeAdapter(aiProvider); | ||
await adapter.isAvailable({ | ||
contents: [{ role: 'user', parts: [{ text: 'hi' }] }] | ||
}); | ||
await adapter.isAvailable({ | ||
contents: [{ role: 'user', parts: [{ text: 'hi' }] }] | ||
}); | ||
expect(createStub).to.have.been.calledOnce; | ||
}); | ||
it('clears state when download completes', async () => { | ||
const aiProvider = { | ||
languageModel: { | ||
capabilities: () => | ||
Promise.resolve({ | ||
available: 'after-download' | ||
}), | ||
create: () => {} | ||
} | ||
} as AI; | ||
let resolveDownload; | ||
const downloadPromise = new Promise<AILanguageModel>(resolveCallback => { | ||
resolveDownload = resolveCallback; | ||
}); | ||
const createStub = stub(aiProvider.languageModel, 'create').returns( | ||
downloadPromise | ||
); | ||
const adapter = new ChromeAdapter(aiProvider); | ||
await adapter.isAvailable({ | ||
contents: [{ role: 'user', parts: [{ text: 'hi' }] }] | ||
}); | ||
resolveDownload!(); | ||
await adapter.isAvailable({ | ||
contents: [{ role: 'user', parts: [{ text: 'hi' }] }] | ||
}); | ||
expect(createStub).to.have.been.calledTwice; | ||
}); | ||
it('returns false when model is never available', async () => { | ||
const aiProvider = { | ||
languageModel: { | ||
capabilities: () => | ||
Promise.resolve({ | ||
available: 'no' | ||
}) | ||
} | ||
} as AI; | ||
const adapter = new ChromeAdapter(aiProvider, 'prefer_on_device'); | ||
expect( | ||
await adapter.isAvailable({ | ||
contents: [{ role: 'user', parts: [{ text: 'hi' }] }] | ||
}) | ||
).to.be.false; | ||
}); | ||
}); | ||
describe('generateContentOnDevice', () => { | ||
it('Extracts and concats initial prompts', async () => { | ||
const aiProvider = { | ||
languageModel: { | ||
create: () => Promise.resolve({}) | ||
} | ||
} as AI; | ||
const factoryStub = stub(aiProvider.languageModel, 'create').resolves({ | ||
prompt: s => Promise.resolve(s) | ||
} as AILanguageModel); | ||
const text = ['first', 'second', 'third']; | ||
const onDeviceParams = { | ||
initialPrompts: [{ role: 'user', content: text[0] }] | ||
} as AILanguageModelCreateOptionsWithSystemPrompt; | ||
const adapter = new ChromeAdapter( | ||
aiProvider, | ||
'prefer_on_device', | ||
onDeviceParams | ||
); | ||
const response = await adapter.generateContentOnDevice({ | ||
contents: [ | ||
{ role: 'model', parts: [{ text: text[1] }] }, | ||
{ role: 'user', parts: [{ text: text[2] }] } | ||
] | ||
}); | ||
expect(factoryStub).to.have.been.calledOnceWith({ | ||
initialPrompts: [ | ||
{ role: 'user', content: text[0] }, | ||
// Asserts tail is passed as initial prompts, and | ||
// role is normalized from model to assistant. | ||
{ role: 'assistant', content: text[1] } | ||
] | ||
}); | ||
expect(await response.json()).to.deep.equal({ | ||
candidates: [ | ||
{ | ||
content: { | ||
parts: [{ text: text[2] }] | ||
} | ||
} | ||
] | ||
}); | ||
}); | ||
it('Extracts system prompt', async () => { | ||
const aiProvider = { | ||
languageModel: { | ||
create: () => Promise.resolve({}) | ||
} | ||
} as AI; | ||
const factoryStub = stub(aiProvider.languageModel, 'create').resolves({ | ||
prompt: s => Promise.resolve(s) | ||
} as AILanguageModel); | ||
const onDeviceParams = { | ||
systemPrompt: 'be yourself' | ||
} as AILanguageModelCreateOptionsWithSystemPrompt; | ||
const adapter = new ChromeAdapter( | ||
aiProvider, | ||
'prefer_on_device', | ||
onDeviceParams | ||
); | ||
const text = 'hi'; | ||
const response = await adapter.generateContentOnDevice({ | ||
contents: [{ role: 'user', parts: [{ text }] }] | ||
}); | ||
expect(factoryStub).to.have.been.calledOnceWith({ | ||
initialPrompts: [], | ||
systemPrompt: onDeviceParams.systemPrompt | ||
}); | ||
expect(await response.json()).to.deep.equal({ | ||
candidates: [ | ||
{ | ||
content: { | ||
parts: [{ text }] | ||
} | ||
} | ||
] | ||
}); | ||
}); | ||
}); | ||
}); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.