[VertexAI] Fix typings for functionDeclaration.parameters. #8948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 24d05ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Vertex AI Mock Responses Check
|
Size Report 1Affected ProductsNo changes between base commit (1363ecc) and merge commit (246ee9f).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (1363ecc) and merge commit (246ee9f).Test Logs |
dlarocque
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8944
This fix allows passing an
ObjectSchemacreated bySchema.object()tofunctionDeclaration.parameterswithout any TS errors. It also forbids passing a plain JSON object tofunctionDeclaration.parametersif it has anoptionalPropertiesproperty, as that is a convenience input method and should not be passed to the backend request. Users can still use therequiredproperty.I experimented with intercepting plain JSON objects passed to
functionDeclaration.parametersand processing theoptionalPropertiesinto arequiredarray but concluded there are too many places this needs to be done (on getGenerativeModel and on each of its methods, possibly on getImagenModel and others in the future) and it adds a lot of unneeded code for a case that can be handled simply by usingSchema.object()or manually filling out therequiredfield.