Adding count token impl #8950

gsiddh · 2025-04-18T22:11:20Z

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

Read the contribution guidelines (CONTRIBUTING.md).
If this has been discussed in an issue, make sure to link to the issue here.
If not, go file an issue about this before creating a pull request to discuss.

Testing

Make sure all existing tests in the repository pass after your change.
If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

At this time we cannot accept changes that affect the public API. If you'd like to help
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.

changeset-bot · 2025-04-18T22:11:23Z

⚠️ No Changeset found

Latest commit: 897c165

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-04-18T22:11:31Z

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v10.0

google-oss-bot · 2025-04-18T22:20:51Z

Size Report ¹

Affected Products

@firebase/vertexai
Type Base (02c4ba7) Merge (a309c3e) Diff
browser 37.7 kB 38.3 kB +544 B (+1.4%)
main 38.7 kB 39.3 kB +544 B (+1.4%)
module 37.7 kB 38.3 kB +544 B (+1.4%)
firebase
Type Base (02c4ba7) Merge (a309c3e) Diff
firebase-vertexai.js 30.4 kB 30.8 kB +349 B (+1.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/gMOi7iv69X.html

google-oss-bot · 2025-04-18T22:32:01Z

Size Analysis Report ¹

Affected Products

`@firebase/vertexai`

`GenerativeModel`

Size

Type	Base (`02c4ba7`)	Merge (`a309c3e`)	Diff
size	19.4 kB	19.5 kB	+132 B (+0.7%)
size-with-ext-deps	38.3 kB	38.5 kB	+132 B (+0.3%)

Dependency

Type Base (02c4ba7) Merge (a309c3e) Diff

functions

25 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
createEnhancedContentResponse
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentOnCloud
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

26 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
countTokensOnCloud
createEnhancedContentResponse
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentOnCloud
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

+ countTokensOnCloud

`ImagenModel`

Size

Type	Base (`02c4ba7`)	Merge (`a309c3e`)	Diff
size	21.1 kB	21.2 kB	+132 B (+0.6%)
size-with-ext-deps	40.1 kB	40.2 kB	+132 B (+0.3%)

Dependency

Type Base (02c4ba7) Merge (a309c3e) Diff

functions

27 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
createEnhancedContentResponse
createPredictRequestBody
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentOnCloud
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
handlePredictResponse
makeRequest
processStream
registerVertex
validateChatHistory

28 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
countTokensOnCloud
createEnhancedContentResponse
createPredictRequestBody
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentOnCloud
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
handlePredictResponse
makeRequest
processStream
registerVertex
validateChatHistory

+ countTokensOnCloud

`VertexAIModel`

Size

Type	Base (`02c4ba7`)	Merge (`a309c3e`)	Diff
size	19.4 kB	19.5 kB	+132 B (+0.7%)
size-with-ext-deps	38.3 kB	38.5 kB	+132 B (+0.3%)

Dependency

Type Base (02c4ba7) Merge (a309c3e) Diff

functions

25 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
createEnhancedContentResponse
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentOnCloud
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

26 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
countTokensOnCloud
createEnhancedContentResponse
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentOnCloud
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

+ countTokensOnCloud

`getGenerativeModel`

Size

Type	Base (`02c4ba7`)	Merge (`a309c3e`)	Diff
size	21.2 kB	21.6 kB	+335 B (+1.6%)
size-with-ext-deps	40.2 kB	40.6 kB	+335 B (+0.8%)

Dependency

Type Base (02c4ba7) Merge (a309c3e) Diff

functions

26 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
createEnhancedContentResponse
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentOnCloud
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getGenerativeModel
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

27 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
countTokensOnCloud
createEnhancedContentResponse
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentOnCloud
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getGenerativeModel
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

+ countTokensOnCloud

`getImagenModel`

Size

Type	Base (`02c4ba7`)	Merge (`a309c3e`)	Diff
size	21.3 kB	21.4 kB	+132 B (+0.6%)
size-with-ext-deps	40.3 kB	40.4 kB	+132 B (+0.3%)

Dependency

Type Base (02c4ba7) Merge (a309c3e) Diff

functions

28 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
createEnhancedContentResponse
createPredictRequestBody
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentOnCloud
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getImagenModel
getResponsePromise
getResponseStream
getText
hadBadFinishReason
handlePredictResponse
makeRequest
processStream
registerVertex
validateChatHistory

29 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
countTokensOnCloud
createEnhancedContentResponse
createPredictRequestBody
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentOnCloud
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getImagenModel
getResponsePromise
getResponseStream
getText
hadBadFinishReason
handlePredictResponse
makeRequest
processStream
registerVertex
validateChatHistory

+ countTokensOnCloud

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/ON4QX309UB.html

Fix languageCode parameter in action_code_url (#8912) * Fix languageCode parameter in action_code_url * Add changeset Vaihi add langmodel types. (#8927) * Adding LanguageModel types. These are based off https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#full-api-surface-in-web-idl * Adding LanguageModel types. * Remove bunch of exports * yarn formatted * after lint Define HybridParams (#8935) Co-authored-by: Erik Eldridge <[email protected]> Adding smoke test for new hybrid params (#8937) * Adding smoke test for new hybrid params * Use the existing name of the model params input --------- Co-authored-by: Erik Eldridge <[email protected]> Moving to in-cloud naming (#8938) Co-authored-by: Erik Eldridge <[email protected]> Moving to string type for the inference mode (#8941) Define ChromeAdapter class (#8942) Co-authored-by: Erik Eldridge <[email protected]> VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943) Adding count token impl (#8950) VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#8949) Define values for Availability enum (#8951) VinF Hybrid Inference: narrow Chrome input type (#8953) Add image inference support (#8954) * Adding image based input for inference * adding image as input to create language model object disable count tokens api for on-device inference (#8962) VinF Hybrid Inference: throw if only_on_device and model is unavailable (#8965)

gsiddh requested a review from a team as a code owner April 18, 2025 22:11

Adding count token impl

31aea9b

gsiddh force-pushed the vaihi-count-tokens branch from 897c165 to 31aea9b Compare April 18, 2025 22:22

erikeldridge self-requested a review April 18, 2025 22:57

erikeldridge approved these changes Apr 18, 2025

View reviewed changes

gsiddh merged commit e069751 into vaihi-exp Apr 18, 2025
34 of 48 checks passed

gsiddh deleted the vaihi-count-tokens branch April 18, 2025 22:59

gsiddh added a commit that referenced this pull request Apr 22, 2025

Adding count token impl (#8950)

cdbe63e

gsiddh added a commit that referenced this pull request Apr 22, 2025

Adding count token impl (#8950)

5d4c7a0

gsiddh mentioned this pull request Apr 23, 2025

Complete Hybrid inference impl #8966

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding count token impl #8950

Adding count token impl #8950

gsiddh commented Apr 18, 2025

changeset-bot bot commented Apr 18, 2025

github-actions bot commented Apr 18, 2025

google-oss-bot commented Apr 18, 2025 •

edited

Loading

`@firebase/vertexai`

`firebase`

google-oss-bot commented Apr 18, 2025 •

edited

Loading

`@firebase/vertexai`

`GenerativeModel`

`ImagenModel`

`VertexAIModel`

`getGenerativeModel`

`getImagenModel`

Adding count token impl #8950

Adding count token impl #8950

Conversation

gsiddh commented Apr 18, 2025

Discussion

Testing

API Changes

changeset-bot bot commented Apr 18, 2025

⚠️ No Changeset found

github-actions bot commented Apr 18, 2025

Vertex AI Mock Responses Check ⚠️

google-oss-bot commented Apr 18, 2025 • edited Loading

Size Report 1

Affected Products

@firebase/vertexai

firebase

Test Logs

google-oss-bot commented Apr 18, 2025 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/vertexai

GenerativeModel

ImagenModel

VertexAIModel

getGenerativeModel

getImagenModel

Test Logs

google-oss-bot commented Apr 18, 2025 •

edited

Loading

Size Report ¹

`@firebase/vertexai`

`firebase`

google-oss-bot commented Apr 18, 2025 •

edited

Loading

Size Analysis Report ¹

`@firebase/vertexai`

`GenerativeModel`

`ImagenModel`

`VertexAIModel`

`getGenerativeModel`

`getImagenModel`