Add support for running the emulators in Cloud Workstation #8968
+317
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e61c657 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check ✅
|
avolkovi
approved these changes
Apr 23, 2025
avolkovi
changed the title
avolkovi
changed the title
avolkovi
changed the title
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (238,599 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Vertex AI Mock Responses Check
|
maneesht
requested review from
a team,
hsubox76,
lisajian,
Xiaoshouzi-gh,
sam-gc,
pashanka,
mansisampat,
NhienLam,
tonyjhuang and
aashishpatil-g
as code owners
avolkovi
approved these changes
Apr 29, 2025
hsubox76
approved these changes
Apr 30, 2025
MarkDuckworth
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Approving with knowledge of the time constraints.
If time allowed, I would consider a more generalized solution where the connection class isn't concerned with special behaviors for certain URLs. Rather it could be parameterized to send this browser managed auth with a flag.
And at a higher level, I'm not sure if this will also be useful to external customers. If so, it could be exposed as a public setting. But that may be a future config, like the discussed SSL option for connectXyzEmulator(...).
If this work needs to be deferred, I'm okay with that too.
| return this.performRPCRequest<Req, Resp>(rpcName, url, headers, req).then( | ||
| const { host } = new URL(url); | ||
| const forwardCredentials = | ||
| isCloudWorkstation(host) && this.databaseInfo.isUsingEmulator; |
There was a problem hiding this comment.
I'm wondering if you need && this.databaseInfo.isUsingEmulator?
Would it be acceptable to only check for isCloudWorkstation(host)?
I'm concerned that a user could connect to the emulator without calling connectFirestoreEmulator(...), simply by using FirestoreSettings. initializeFirestore(app, { host: cloudWorkstationUrl, ssl: true, port: 443 }). Using that path, it appears that isUsingEmulator would be set to false.
And it may be the agent that attempts to connect that way, not be a developer choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an app is connected to Firebase Studio, then we should use credentials along with each request, to ensure that the auth cookie for the workstation is forwarded to each request in the emulator.
Products Affected: