VinF Hybrid Inference: disable multi-turn support #8973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
We can't differentiate roles until Chrome supports the LanguageModelMessage type.
Multi-turn requests differentiate turns by role, so without roles, we can't support multi-turn.
We can't throw to indicate a lack of support, like we can with countToken, because ChromeAdapter integrates below
ChatSession.
Bug: b/413402604
Proposal
This change indicates a lack of support for multi-turn requests by updating the request validator to fail if a request contains non-"user" roles. We can relax this once LanguageModelMessage is released.