Skip to content

Remove label annotations for genkit functions; they break #8127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

inlined
Copy link
Member

@inlined inlined commented Jan 22, 2025

Ran into an error testing out onCallGenkit. Turns out that Run labels can only have [a-z0-9_-]. We need both capital letters and slashes. Run annotations supports that, but they are unavailable until after a migration to CRF.

@inlined inlined requested review from joehan and taeold January 22, 2025 03:20
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems fine to me, though I don't know the use case here. If it makes sense here, consider label encoding the genkit action name instead of omitting it entirely?

Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, add a changelog entry if appropriate

@inlined
Copy link
Member Author

inlined commented Jan 22, 2025

I'm not sure encoding is the best idea because the encoded value will be visible to the users through the Cloud console. I can chat with the genkit team and re-add if they want (since it would provide deployment metrics, though the pipeline would be torn down and rebuilt in CRF). In the meantime I'd like to just unblock the launch.

Not adding relnotes because it's a bugfix of an unreleased feature. LMK if you disagree and I'll add them

@inlined inlined merged commit 341a6e0 into master Jan 22, 2025
45 of 46 checks passed
@inlined inlined deleted the inlined.no-labels branch January 22, 2025 17:40
@joehan
Copy link
Contributor

joehan commented Jan 22, 2025

I'm not sure encoding is the best idea because the encoded value will be visible to the users through the Cloud console. I can chat with the genkit team and re-add if they want (since it would provide deployment metrics, though the pipeline would be torn down and rebuilt in CRF). In the meantime I'd like to just unblock the launch.

Not adding relnotes because it's a bugfix of an unreleased feature. LMK if you disagree and I'll add them

SGTM on both points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants