-
Notifications
You must be signed in to change notification settings - Fork 257
Update firebase-ui dependency to support Auth emulator #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Any updates to this PR? |
@jhuleatt can you help? |
Trying this change locally, my |
Yup confirmed that is an issue with the base firebase-web SDK tracked here and appears to be limited to Twitter auth |
@zackdotcomputer how did you test this locally? It seems like this hasn't been merged yet nor published as a package. EDIT: realizing that you may have tested this within this package, not in another app which uses |
@paymog I did actually test this in my project. Personally I tested it by using the package.json You could also test it more directly by depending directly on the code from @chetbox's github with |
Hey @chetbox thanks for the PR! Since there are some merge conflicts after #122, I updated the |
Thanks @jhuleatt! |
Updates the
firebase-ui
dependency to support Firebase Auth emulatorResolves #118