Skip to content

Update firebase-ui dependency to support Auth emulator #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update firebase-ui dependency to support Auth emulator #125

wants to merge 1 commit into from

Conversation

chetbox
Copy link

@chetbox chetbox commented Feb 4, 2021

Updates the firebase-ui dependency to support Firebase Auth emulator

Resolves #118

@google-cla
Copy link

google-cla bot commented Feb 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@chetbox
Copy link
Author

chetbox commented Feb 4, 2021

@googlebot I signed it!

@chetbox chetbox changed the title Update firebase-ui dependency Update firebase-ui dependency to support Auth emulator Feb 7, 2021
@locona
Copy link

locona commented Mar 4, 2021

Any updates to this PR?

@chetbox
Copy link
Author

chetbox commented Mar 4, 2021

@jhuleatt can you help?

@zackdotcomputer
Copy link

Trying this change locally, my StyledFirebaseAuth component does not successfully call-back from an emulated auth when using fake-Twitter. I'm assuming this is a bug higher up the chain and not merge-blocking for this but figured I'd report it.

@zackdotcomputer
Copy link

zackdotcomputer commented Mar 13, 2021

Yup confirmed that is an issue with the base firebase-web SDK tracked here and appears to be limited to Twitter auth

@paymog
Copy link

paymog commented Mar 23, 2021

@zackdotcomputer how did you test this locally? It seems like this hasn't been merged yet nor published as a package.

EDIT: realizing that you may have tested this within this package, not in another app which uses react-firebaseui - my bad!

@zackdotcomputer
Copy link

@paymog I did actually test this in my project. Personally I tested it by using the package.json resolutions field to override the react-firebaseui/firebaseui version, recreating the same effect that this PR would have when merged.

You could also test it more directly by depending directly on the code from @chetbox's github with npm install --save chetbox/firebaseui-web-react#update-firebase-ui

@jhuleatt
Copy link
Contributor

Hey @chetbox thanks for the PR! Since there are some merge conflicts after #122, I updated the firebase-ui dependency in commit 54cc2eb and gave you co-author credit. It's now available in [email protected]

@jhuleatt jhuleatt closed this Apr 26, 2021
@chetbox
Copy link
Author

chetbox commented Apr 26, 2021

Thanks @jhuleatt!

@chetbox chetbox deleted the update-firebase-ui branch April 26, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants