Skip to content

Refactor/change lifecycle method in examples #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2018
Merged

Refactor/change lifecycle method in examples #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36de99a
docs(README): change componentWillMount to componentDidMount
kristofdombi Feb 18, 2018
d328352
refactor(example): change componentWillMount to componentDidMount
kristofdombi Feb 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class SignInScreen extends React.Component {
};

// Listen to the Firebase Auth state and set the local state.
componentWillMount() {
componentDidMount() {
firebase.auth().onAuthStateChanged(
(user) => this.setState({signedIn: !!user})
);
Expand Down
2 changes: 1 addition & 1 deletion example/src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class App extends React.Component {
/**
* @inheritDoc
*/
componentWillMount() {
componentDidMount() {
firebaseApp.auth().onAuthStateChanged((user) => {
this.setState({signedIn: !!user});
});
Expand Down