Skip to content

Removed node_modules from cleanup; updated firebase dependency #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2019
Merged

Removed node_modules from cleanup; updated firebase dependency #65

merged 1 commit into from
May 7, 2019

Conversation

paulywill
Copy link
Contributor

Trying to follow the README.md instructions do not work.

As discovered in #53 by @juanmaguitar, by removing the node_modules in the cleanup line called by the build, the build will run successfully locally.

In addition, I had to update the firebase dependency to resolve an npm install: node-pre-gyp error.

image

After Changes:

image

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@paulywill
Copy link
Contributor Author

paulywill commented Apr 28, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

Sign it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@wti806 wti806 merged commit 7f87632 into firebase:master May 7, 2019
@jhuleatt jhuleatt linked an issue Apr 26, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'extract-text-webpack-plugin'
3 participants