Add generic tests for polynomial types #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarbenjamin
commented
Sep 29, 2023
Comment on lines
+1817
to
+1831
| def _all_polys(): | ||
| return [ | ||
| # (poly_type, scalar_type, is_field) | ||
| (flint.fmpz_poly, flint.fmpz, False), | ||
| (flint.fmpq_poly, flint.fmpq, True), | ||
| (lambda *a: flint.nmod_poly(*a, 17), lambda x: flint.nmod(x, 17), True), | ||
| ] | ||
|
|
||
|
|
||
| def test_polys(): | ||
| for P, S, is_field in _all_polys(): | ||
|
|
||
| assert P([S(1)]) == P([1]) == P(P([1])) == P(1) | ||
|
|
||
| assert raises(lambda: P([None]), TypeError) |
There was a problem hiding this comment.
@GiacomoPope if we write the tests more like this then we don't need to duplicate the test code for different types and it also means that we can test that the different types have consistent method names and signatures.
There was a problem hiding this comment.
Yeah I agree with this. I think once #87 is merged I will take the time to address the tests before working on fq types.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test_polys function that runs the same same generic tests over
fmpz_poly,fmpq_polyandnmod_polyto share tests and ensure that the interfaces of the three types are consistent where appropriate. Some methods that were present on some types but not on others were added.