Add support for mapping translation parameters #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export Sizefluent-vue
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
+ Coverage 99.52% 99.54% +0.01%
==========================================
Files 12 12
Lines 212 218 +6
Branches 43 45 +2
==========================================
+ Hits 211 217 +6
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Demivan
force-pushed
the
map-variables
branch
2 times, most recently
from
4dc86e5 to
e676766
Compare
commit: |
Demivan
force-pushed
the
map-variables
branch
from
e676766 to
43ebd52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow passing a function to map translation parameters to
FluentVariable. This enables support for types that fluent.js does not support; for example: Intl.Temporal, raw objects, null, undefined.Linked Issues
Closes #917
Additional context