Skip to content

Improve directive SSR #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Improve directive SSR #921

merged 4 commits into from
Feb 14, 2025

Conversation

Demivan
Copy link
Member

@Demivan Demivan commented Feb 14, 2025

Description

Fixes binding of textContent with v-t directive during the SSR.

Linked Issues

Additional context

vuejs/core#8112 was preventing directives from binding textContent and innerHTML. It is fixed now.

Copy link

github-actions bot commented Feb 14, 2025

Export Size

fluent-vue

Name Size Diff
createFluentVue 2.53 KB -12 B (-0.46%) 🔽
Unchanged

fluent-vue

Name Size Diff
useFluent 923 B -

@Demivan Demivan added the Type: Improvement :zap: Improved Features label Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0fe0acb) to head (d12d01c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #921      +/-   ##
===========================================
+ Coverage   98.12%   100.00%   +1.87%     
===========================================
  Files          12        12              
  Lines         213       210       -3     
  Branches       42        42              
===========================================
+ Hits          209       210       +1     
+ Misses          2         0       -2     
+ Partials        2         0       -2     
Flag Coverage Δ
vue-2 89.04% <0.00%> (+1.25%) ⬆️
vue-3 92.38% <100.00%> (+1.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Demivan Demivan merged commit c455080 into main Feb 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement :zap: Improved Features
Development

Successfully merging this pull request may close these issues.

1 participant