Fix group handling for widget tests (#1249). #1258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Aug 3, 2017
There was a problem hiding this comment.
lgtm
@pq, can you open an issue to upstream the necessary changes to DartTestEventsConverterZ.java and DartTestLocationProviderZ.java (access related?); I'm worried about the technical debt we'll accumulate otherwise -
| private static boolean isSyntheticWidgetTestGroup(@NotNull Group group) { | ||
| return Objects.equals(group.getUrl(), "package:flutter_test/src/widget_tester.dart") && | ||
| Objects.equals(group.getName(), SYNTHETIC_WIDGET_GROUP_NAME); | ||
| private static boolean isSyntheticWidgetTestGroup(@Nullable Item group) { |
| Objects.equals(group.getName(), SYNTHETIC_WIDGET_GROUP_NAME); | ||
| private static boolean isSyntheticWidgetTestGroup(@Nullable Item group) { | ||
| return group instanceof Group && Objects.equals(group.getUrl(), "package:flutter_test/src/widget_tester.dart") && | ||
| group.getName().endsWith(SYNTHETIC_WIDGET_GROUP_NAME); |
There was a problem hiding this comment.
I'm guessing group.getName() will always be non-null?
There was a problem hiding this comment.
Well, I think so but I'm not sure it's specified so better safe than sorry; will fix.
Thanks!
|
#1260 opened to track upstreaming 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1249.
@stevemessick @devoncarew