fix: Additional checks for prefer-flat #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doniyor2109
changed the title
freaktechnik
requested changes
Feb 26, 2020
rules/prefer-flat.js
Outdated
| @@ -1,3 +1,5 @@ | |||
| // eslint-disable-next-line eslint-comments/disable-enable-pair | |||
| /* eslint-disable no-magic-numbers */ | |||
There was a problem hiding this comment.
I'm sorry, but these rules are there for a reason.
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 111 111
=========================================
Hits 111 111 Continue to review full report at Codecov.
|
freaktechnik
approved these changes
Feb 26, 2020
| if(node.parent.parent.arguments.length > SECOND && node.parent.parent.arguments[SECOND].type === "ArrayExpression" && | ||
| firstElement(node.arguments).name === node.parent.params[SECOND].name && | ||
| node.callee.object.name === firstElement(node.parent.params).name) { | ||
| 'CallExpression[callee.type="MemberExpression"][callee.property.name="reduce"][arguments.length=2][arguments.1.type=ArrayExpression][arguments.1.elements.length=0] > *:function[params.length=2][params.0.type=Identifier][params.1.type=Identifier] > CallExpression[callee.type="MemberExpression"][callee.property.name="concat"][arguments.length=1][arguments.0.type=Identifier]'(node) { |
There was a problem hiding this comment.
Oh wow, I didn't expect this much to be possible within the selector. Nice work!
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefer-flatis failing in some cases:array.reduce((p, []) => p.concat({}), [])array.reduce((p, n) => p.concat(n), [1])array.reduce((p, n) => p.concat(n, n), [])