Fetch dispatches in sync with periodic reconnect of client.stream #155
+41
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
llucax
reviewed
May 22, 2025
Marenz
force-pushed
the
periodic-event-check
branch
from
ba62a7a to
a79b3e3
Compare
github-actions
bot
added
the
part:tooling
Marenz
changed the title
Marenz
added
the
status:blocked
To ensure we didn't miss any. Signed-off-by: Mathias L. Baumann <[email protected]>
Marenz
force-pushed
the
periodic-event-check
branch
from
a79b3e3 to
b5aff78
Compare
Unfortunately, using a new base-client also means allowing a new base client version in microclient, so we will have to release both base-client and microclient |
|
"microclient" 😆 |
llucax
reviewed
Jun 2, 2025
| await self._lifecycle_events_tx.send(Deleted(dispatch=dispatch)) | ||
| match selected.message: | ||
| case StreamStartedEvent(): | ||
| _logger.info("Dispatch stream restarted, refreshing dispatches") |
There was a problem hiding this comment.
Realistically we never will get the start notification because we create the new_receiver() only after it was sent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should probably use
frequenz-floss/frequenz-client-base-python#141
eventually to be less hacky?