Skip to content

Using patch #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2018
Merged

Using patch #426

merged 1 commit into from
Dec 3, 2018

Conversation

dolezel
Copy link
Collaborator

@dolezel dolezel commented Dec 3, 2018

@wuweiweiwu Patching react-dnd-scrollzone is probably better than using fork

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.789% when pulling d1f0831 on dolezel:patch_package into 9343a55 on frontend-collective:master.

wuweiweiwu
wuweiweiwu approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Can you also look into getting this patch into scroll zone? or we can fork it under front end collective and publish our own

@wuweiweiwu wuweiweiwu merged commit 1a47241 into frontend-collective:master Dec 3, 2018
@dolezel
Copy link
Collaborator Author

dolezel commented Dec 3, 2018

I raised PR azuqua/react-dnd-scrollzone#40
But reading comments on azuqua/react-dnd-scrollzone#38 it looks it may not be merged any time soon, or ever.
Can you release support for react-dnd 6?

I think this patch is sufficient for now, but would consider maintaining fork of react-dnd-scrollzone under frond end collective if there would be needed more changes.

You can also consider enabling https://renovatebot.com/ for maintaining up to date dependencies.

@wuweiweiwu wuweiweiwu mentioned this pull request Dec 10, 2018
Closed
@dolezel dolezel deleted the patch_package branch December 10, 2018 09:43
@dolezel dolezel restored the patch_package branch December 10, 2018 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuweiweiwu wuweiweiwu wuweiweiwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dolezel @coveralls @wuweiweiwu