Create parent directories in get_file #1282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows test failing as a result of the usual different path separators. I will have to investigate further. |
We should hold the PR, then? Maybe we should replace os.makedirs with LocalFileSystem.makedirs, which should do path normalisation ? |
|
Yes, hold the PR until I have looked again. |
|
OK, this is good now using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix when calling
getwith a file to get it into a new (i.e. doesn't exist yet) directory we need to create the parent directory to put the file in. The issue was discovered as part of the newcp/get/puttest harness (#1267). With this fix allmemoryfilesystem tests pass whereas before this the 4 "get file/directory/glob into a new directory" tests all failed as the parent directory wasn't auto created.