Skip to content

signInWithProvider argument mismatch #282

Open
@ThaNarie

Description

@ThaNarie

I'm getting an argument mismatch on the signInWithProvider function, expected 4, received 2.
I'm using the v3 branch.

The Java code expects 4 arguments (3 + callback/promise).

public void signInWithProvider(final String provider, final String authToken, final String authSecret, final Callback callback) {

But the JS code sends an object as first argument.

return promisify('signInWithProvider', FirestackAuth)(credential);

The link function seems to be correctly updated:

return promisify('link', FirestackAuth, 'auth/')(credential.provider, credential.token, credential.secret);

Changing the code to this seems to work:

signInWithCredential(credential: any): Promise<Object> {
  return promisify('signInWithProvider', FirestackAuth)(credential.provider, credential.token, credential.secret);
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions