Skip to content

Allow Symfony 6 #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2021
Merged

Allow Symfony 6 #319

merged 1 commit into from
Dec 14, 2021

Conversation

norkunas
Copy link
Member

@norkunas norkunas commented Nov 9, 2021

No description provided.

@norkunas norkunas requested a review from Nyholm November 9, 2021 05:42
@norkunas norkunas force-pushed the sf6 branch 13 times, most recently from e16c4d0 to dcd60fd Compare November 9, 2021 06:42
@norkunas
Copy link
Member Author

norkunas commented Nov 9, 2021

PHP-CS-Fixer/PHP-CS-Fixer#6095 blocker

@norkunas norkunas force-pushed the sf6 branch 2 times, most recently from b1d9d3e to 7f2852a Compare November 9, 2021 06:56
@ruudk
Copy link

ruudk commented Dec 8, 2021

FriendsOfPHP/PHP-CS-Fixer#6095 blocker

How is this a blocker? The PHP-CS-Fixer step fails with

Warning: Found violation(s) of type: ordered_imports

I think you just need to fix that and it's done :)

@norkunas
Copy link
Member Author

norkunas commented Dec 8, 2021

it was because sf6 was not supported along cs-fixer, I see it's merged, will update this soon

@norkunas norkunas force-pushed the sf6 branch 5 times, most recently from 1ae1a69 to 814675f Compare December 8, 2021 12:02
@norkunas
Copy link
Member Author

norkunas commented Dec 8, 2021

Another blocker is https://github.com/php-http/curl-client which has a PR for sf6 support

@ruudk
Copy link

ruudk commented Dec 8, 2021

For reference:

@norkunas norkunas force-pushed the sf6 branch 4 times, most recently from 9579943 to 09b285f Compare December 9, 2021 15:13
@norkunas norkunas force-pushed the sf6 branch 6 times, most recently from 1e537cf to 5849fda Compare December 9, 2021 15:41
@core23 core23 mentioned this pull request Dec 9, 2021
Merged
@Chris53897
Copy link

@norkunas Thanks for the PR. Now that the curl-client blocker is gone, can you please force push to rerun the tests?

@norkunas norkunas force-pushed the sf6 branch 11 times, most recently from 9e6fe86 to 9967e5a Compare December 13, 2021 14:25
@norkunas
Copy link
Member Author

norkunas commented Dec 13, 2021 •
edited
Loading

green&peace. at last.

@Nyholm I've currently restored to use curl client instead of mock client to lower size of changes for easier review.

Nyholm
Nyholm approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thank you.

I think (maybe) it is a good idea to call the parent's method in the ORM test.

@norkunas norkunas merged commit c9318d5 into geocoder-php:master Dec 14, 2021
@norkunas norkunas deleted the sf6 branch December 14, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@norkunas @ruudk @Chris53897 @Nyholm