-
Notifications
You must be signed in to change notification settings - Fork 110
load fakeip plugin before cache #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like that probably of all providers used versions are gone.. will need to resolve this |
Could you rebase? And also would be nice if we'd have a test for this, to prove that this works :) |
0a2424c
to
bc075df
Compare
0c640cc
to
160f0ef
Compare
Thank you |
I made a test attempt (ruano-a@8cf88d9), but the former issue doesn't seem to happen in the context of the test (I've put the plugin loading in the former order). I don't know if the cache is forcefully turned off somewhere, or if recreating a kernel clears it... |
Looking at the https://github.com/SymfonyTest/symfony-bundle-test/blob/master/src/TestKernel.php there is an option |
Thanks it was indeed useful, unfortunately it wasn't enough. But it's done, should I put in the same branch for a "remerge", or a new pull request? (I'll rebase if needed, and squash at least the 2 commits related to the test) |
New PR please :) |
Done #338 |
The FakeIpPlugin is now loaded before the CachePlugin, to make the cache based on the fake ip, therefore invalidating it if we change the fake_ip in the config.
Cf #334