Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Detection of Google App Engine and AWS lambda does not work #1192

Open
@mdornseif

Description

@mdornseif

tl;dr The fix in [GH-816] does not work but makes things worse by producing misleading log messages.

The code in https://github.com/getsentry/raven-python/blob/master/raven/conf/remote.py#L36
Should result in synchronous HTTP transport selection on AWS Lambda and Google App Engine. It produce a log entry which gives the user the feeling
that raven would use synchronous HTTP transport now unless otherwise instructed.

This selection is only honored if later on RemoteConfig() is used.

But RemoteConfig.from_string() uses TransportRegistry(default_transports).
This completly ignores the DEFAULT_TRANSPORT set above.

This comment on GH-816 shows that the fix in 83984a2 does not
work. The logging information shown gives a false sense of working auto configuration.

To my understanding in the normal use caseClient(dsn) calls set_dsn(dsn) and this calls
RemoteConfig.from_string() whenever an DSN is given.

So you get a ThreadedHTTPTrasport although the Logging Message during the Import of
raven.conf.remote suggests otherwise. The result of this is that normal HTTP-Requests to Google AppEngine take 60 seconds whenever an error happens.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions