Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Only fetch context when sending exception and message #635

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions raven/contrib/flask.py
Original file line number Diff line number Diff line change
Expand Up @@ -217,10 +217,11 @@ def get_http_info_with_retriever(self, request, retriever=None):
'env': dict(get_environ(request.environ)),
}

def before_request(self, *args, **kwargs):
self.last_event_id = None
self.client.http_context(self.get_http_info(request))
self.client.user_context(self.get_user_info(request))
def update_context(self):
if 'request' not in self.client.context:
self.client.http_context(self.get_http_info(request))
if 'user' not in self.client.context:
self.client.user_context(self.get_user_info(request))

def after_request(self, sender, response, *args, **kwargs):
if self.last_event_id:
Expand Down Expand Up @@ -261,8 +262,6 @@ def init_app(self, app, dsn=None, logging=None, level=None, wrap_wsgi=None,
if self.wrap_wsgi:
app.wsgi_app = SentryMiddleware(app.wsgi_app, self.client)

app.before_request(self.before_request)

if self.register_signal:
got_request_exception.connect(self.handle_exception, sender=app)
request_finished.connect(self.after_request, sender=app)
Expand All @@ -273,6 +272,7 @@ def init_app(self, app, dsn=None, logging=None, level=None, wrap_wsgi=None,

def captureException(self, *args, **kwargs):
assert self.client, 'captureException called before application configured'
self.update_context()
result = self.client.captureException(*args, **kwargs)
if result:
self.last_event_id = self.client.get_ident(result)
Expand All @@ -282,6 +282,7 @@ def captureException(self, *args, **kwargs):

def captureMessage(self, *args, **kwargs):
assert self.client, 'captureMessage called before application configured'
self.update_context()
result = self.client.captureMessage(*args, **kwargs)
if result:
self.last_event_id = self.client.get_ident(result)
Expand Down