feat(statsd): Measure number of project config attempts [INGEST-1324] #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
changed the title
untitaker
approved these changes
May 30, 2022
jan-auer
approved these changes
May 30, 2022
Comment on lines
+269
to
+272
| metric!( | ||
| histogram(RelayHistograms::ProjectStateAttempts) = | ||
| channel.attempts | ||
| ); |
There was a problem hiding this comment.
How does this work with retries? If relay makes an attempt and fails, this will record an attempt. If relay fails the following attempt, does this record 2? So 1 + 2 = 3, when it should be 1 + 1 = 2.
There was a problem hiding this comment.
Because of the continue on line 253, this code only executes when the endpoint returned an actual state in the configs object. The actual arithmetic on attempts happens on line 203:
When a project key is in the pending list, it is re-inserted into state_channels, so it will increment the count:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track a metric for how often project configs are re-attempted, either because they received a "pending" response or an error response.
#skip-changelog