docs(react-router): Add docs for distributed tracing #13467
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
| <Expandable title="Do you need to customize your handleRequest function?"> | ||
| If you need to update the logic of your `handleRequest` function you'll need to include the provided Sentry helper functions (`getMetaTagTransformer` and `wrapSentryHandleRequest`) manually: |
There was a problem hiding this comment.
Do I understand this correctly that this more manual approach is necessary when users have their own handleRequest function already? If so, I think we should point this out more clearly because I didn't fully understand the "If you need to update the logic of your handleRequest function" part. (Maybe that's just me though, so feel free to disregard)
| <Expandable title="Do you need to customize your handleRequest function?"> | |
| If you need to update the logic of your `handleRequest` function you'll need to include the provided Sentry helper functions (`getMetaTagTransformer` and `wrapSentryHandleRequest`) manually: | |
| <Expandable title="Do you have your own handleRequest function?"> | |
| If already defined your own `handleRequest` function you'll need to include the provided Sentry helper functions (`getMetaTagTransformer` and `wrapSentryHandleRequest`) manually: |
(feel free to go with different wording as you see fit
There was a problem hiding this comment.
yeah that is correct, BUT whenever a user creates this hook, the handleRequest function is already defined – so I only want to encourage this path when they need some special logic in their function .. not sure how to name this though
There was a problem hiding this comment.
Maybe I don't fully understand this yet but I guess what you mean is that when you run react-router reveal there already is a predefined handleRequest and this is the one users don't need to add Sentry stuff to?
So it's just for the case that users have a custom behaviour in the function already prior to adding Sentry?
I don't think this is a blocker btw, so if you wanna merge this today, feel free. Maybe we have a minute tomorrow to chat about it this quickly in person
There was a problem hiding this comment.
Yeah let's talk talk about this tomorrow 👍
|
Probably unrelated to this specific PR but I noticed that the 
|
documents getsentry/sentry-javascript#16070