Skip to content

Only send {{auto}} ip-adress if sendDefaultPii is enabled (7.x.x) #4071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2025
Merged

Only send {{auto}} ip-adress if sendDefaultPii is enabled (7.x.x) #4071

merged 2 commits into from
Jan 20, 2025

Conversation

markushi
Copy link
Member

📜 Description

Fixes #4068

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@markushi markushi changed the title Only send {{auto}} ip-adress if sendDefaultPii is enabled Only send {{auto}} ip-adress if sendDefaultPii is enabled (7.x.x) Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 464.15 ms 489.02 ms 24.88 ms
Size 1.70 MiB 2.36 MiB 670.21 KiB

adinauer
adinauer approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markushi markushi merged commit 3cdb905 into 7.x.x Jan 20, 2025
30 checks passed
@markushi markushi deleted the markushi/feat/auto-ip-address-only-when-send-default-pii branch January 20, 2025 15:47
@vaind vaind mentioned this pull request Jan 21, 2025
Merged
@krystofwoldrich krystofwoldrich mentioned this pull request Feb 3, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer adinauer approved these changes

@stefanosiano stefanosiano stefanosiano approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markushi @adinauer @stefanosiano