Skip to content

feat: Update Next.js 13.2.0 to v8.0.0-beta.4 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Apr 22, 2024

No description provided.

"sample_rate": "1",
"sampled": "true",
"trace_id": "[[ID2]]",
"transaction": "BaseServer.renderToResponse"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so whyyyy is this coming in here? 🤔 we should be filtering these out, at least I thought so... @lforst could you also give this a look?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Next.js didn't have the next.span_type attributes yet in that version 🤔 We need to find another way of filtering them.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the transactions are still missing 🤔 Normally, a "transaction" is saved and when an error happens, a "transaction" and "event" file is saved. In this setup the transaction is missing sometimes (see "Files Changed"). In those cases, another file is created that is based on the transaction name (which is BaseServer or similar).

@s1gr1d s1gr1d changed the title feat: Update Next.js 13.2.0 to v8.0.0-beta.3 feat: Update Next.js 13.2.0 to v8.0.0-beta.4 Apr 26, 2024
@s1gr1d
Copy link
Member Author

s1gr1d commented Jun 17, 2024

merged here: #33

@s1gr1d s1gr1d closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants