ref(utils): remove forget async utility function (#4941)

remove the `forget()` function from Utils as it is a rather unnecessary abstraction around logging a rejected Promise via console.error and it bloats the bundle

Author: Lms24

packages/browser/src/transports/utils.ts

@@ -1,4 +1,4 @@
-import { forget, getGlobalObject, isNativeFetch, logger, supportsFetch } from '@sentry/utils';
+import { getGlobalObject, isNativeFetch, logger, supportsFetch } from '@sentry/utils';
 
 import { IS_DEBUG_BUILD } from '../flags';
 
@@ -98,13 +98,11 @@ export function sendReport(url: string, body: string): void {
 
   if (supportsFetch()) {
     const fetch = getNativeFetchImplementation();
-    return forget(
-      fetch(url, {
-        body,
-        method: 'POST',
-        credentials: 'omit',
-        keepalive: true,
-      }),
-    );
+    fetch(url, {
+      body,
+      method: 'POST',
+      credentials: 'omit',
+      keepalive: true,
+    }).then(null, error => logger.error(error));
   }
 }

packages/node/src/integrations/utils/errorhandling.ts

@@ -1,5 +1,5 @@
 import { getCurrentHub } from '@sentry/core';
-import { forget, logger } from '@sentry/utils';
+import { logger } from '@sentry/utils';
 
 import { NodeClient } from '../../client';
 import { IS_DEBUG_BUILD } from '../../flags';
@@ -24,12 +24,13 @@ export function logAndExitProcess(error: Error): void {
   const timeout =
     (options && options.shutdownTimeout && options.shutdownTimeout > 0 && options.shutdownTimeout) ||
     DEFAULT_SHUTDOWN_TIMEOUT;
-  forget(
-    client.close(timeout).then((result: boolean) => {
+  client.close(timeout).then(
+    (result: boolean) => {
       if (!result) {
         IS_DEBUG_BUILD && logger.warn('We reached the timeout for emptying the request buffer, still exiting now!');
       }
       global.process.exit(1);
-    }),
+    },
+    error => logger.error(error),
   );
 }

packages/utils/src/async.ts

@@ -1,4 +1,3 @@
-export * from './async';
 export * from './browser';
 export * from './dsn';
 export * from './error';