Skip to content

Commit 2fbd835

Browse files
authored
Revert "fix(replay): Generate uuids for replay events (#6650)" (#6668)
This reverts commit e6350d6.
1 parent 5a0a1f9 commit 2fbd835

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

packages/replay/src/replay.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -939,7 +939,7 @@ export class ReplayContainer implements ReplayContainerInterface {
939939
replay_type: this.session?.sampled,
940940
};
941941

942-
const replayEvent = await getReplayEvent({ scope, client, event: baseEvent });
942+
const replayEvent = await getReplayEvent({ scope, client, replayId, event: baseEvent });
943943

944944
if (!replayEvent) {
945945
// Taken from baseclient's `_processEvent` method, where this is handled for errors/transactions
@@ -972,7 +972,7 @@ export class ReplayContainer implements ReplayContainerInterface {
972972
"segment_id": 3,
973973
"replay_type": "error",
974974
"platform": "javascript",
975-
"event_id": "generated-uuid",
975+
"event_id": "eventId",
976976
"environment": "production",
977977
"sdk": {
978978
"integrations": [

packages/replay/src/util/getReplayEvent.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,15 @@ import { Client, ReplayEvent } from '@sentry/types';
44
export async function getReplayEvent({
55
client,
66
scope,
7+
replayId: event_id,
78
event,
89
}: {
910
client: Client;
1011
scope: Scope;
12+
replayId: string;
1113
event: ReplayEvent;
1214
}): Promise<ReplayEvent | null> {
13-
const preparedEvent = (await prepareEvent(client.getOptions(), event, {}, scope)) as ReplayEvent | null;
15+
const preparedEvent = (await prepareEvent(client.getOptions(), event, { event_id }, scope)) as ReplayEvent | null;
1416

1517
// If e.g. a global event processor returned null
1618
if (!preparedEvent) {

packages/replay/test/unit/util/getReplayEvent.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,11 @@ describe('getReplayEvent', () => {
3333
trace_ids: ['trace-ID'],
3434
urls: ['https://sentry.io/'],
3535
replay_id: replayId,
36+
event_id: replayId,
3637
segment_id: 3,
3738
};
3839

39-
const replayEvent = await getReplayEvent({ scope, client, event });
40+
const replayEvent = await getReplayEvent({ scope, client, replayId, event });
4041

4142
expect(replayEvent).toEqual({
4243
type: 'replay_event',
@@ -47,8 +48,7 @@ describe('getReplayEvent', () => {
4748
replay_id: 'replay-ID',
4849
segment_id: 3,
4950
platform: 'javascript',
50-
// generated uuid with 32 chars
51-
event_id: expect.stringMatching(/^\w{32}$/),
51+
event_id: 'replay-ID',
5252
environment: 'production',
5353
sdk: {
5454
name: 'sentry.javascript.browser',

0 commit comments

Comments
 (0)