Skip to content

fix(replay): Generate uuids for replay events #6650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2023
Merged

fix(replay): Generate uuids for replay events #6650

merged 1 commit into from
Jan 4, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 4, 2023

Instead of using the replay_id, we let sentry generate uuids for the event_id instead. Otherwise, multiple events will have the same event_id, which is not ideal. This still works because right now we do not actually use the event_id there, but for consistency it is better to have this be unique.

Closes #6649

@mydea
fix(replay): Generate uuids for replay events
6c66fa5 
Instead of using the `replay_id`, we let sentry generate uuids for the `event_id` instead. Otherwise, multiple events will have the same `event_id`, which is not ideal. This still works because right now we do not actually use the `event_id` there, but for consistency it is better to have this be unique.
@mydea mydea requested review from billyvg and Lms24 January 4, 2023 09:25
@mydea mydea self-assigned this Jan 4, 2023
Lms24
Lms24 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for taking care of this so quickly.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.8 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.29 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.58 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 54.88 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.34 KB (0%)
@sentry/browser - Webpack (minified) 66.46 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.36 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.62 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.75 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.2 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.97 KB (-0.03% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.67 KB (-0.02% 🔽)

@mydea mydea merged commit e6350d6 into master Jan 4, 2023
@mydea mydea deleted the fn/replay-eventId branch January 4, 2023 15:10
Lms24 added a commit that referenced this pull request Jan 5, 2023
@Lms24
Revert "fix(replay): Generate uuids for replay events (#6650)"
bca0e34 
This reverts commit e6350d6.
Lms24 added a commit that referenced this pull request Jan 5, 2023
@Lms24
Revert "fix(replay): Generate uuids for replay events (#6650)"
a33da56 
This reverts commit e6350d6.
@Lms24 Lms24 mentioned this pull request Jan 5, 2023
Merged
Lms24 added a commit that referenced this pull request Jan 9, 2023
@Lms24
Revert "fix(replay): Generate uuids for replay events (#6650)" (#6668)
2fbd835 
This reverts commit e6350d6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replay events should have a unique event_id
3 participants
@mydea @billyvg @Lms24