Merge pull request #10923 from getsentry/prepare-release/8.0.0-alpha.2

meta(changelog): Update changelog for v8.0.0-alpha.2

Author: mydea

.craft.yml

@@ -91,9 +91,6 @@ targets:
   - name: npm
     id: '@sentry/serverless'
     includeNames: /^sentry-serverless-\d.*\.tgz$/
-  - name: npm
-    id: '@sentry/opentelemetry-node'
-    includeNames: /^sentry-opentelemetry-node-\d.*\.tgz$/
   - name: npm
     id: '@sentry/bun'
     includeNames: /^sentry-bun-\d.*\.tgz$/
@@ -194,8 +191,6 @@ targets:
         onlyIfPresent: /^sentry-svelte-\d.*\.tgz$/
       'npm:@sentry/sveltekit':
         onlyIfPresent: /^sentry-sveltekit-\d.*\.tgz$/
-      'npm:@sentry/opentelemetry-node':
-        onlyIfPresent: /^sentry-opentelemetry-node-\d.*\.tgz$/
       'npm:@sentry/bun':
         onlyIfPresent: /^sentry-bun-\d.*\.tgz$/
       'npm:@sentry/vercel-edge':

.github/ISSUE_TEMPLATE/bug.yml

@@ -31,7 +31,7 @@ body:
         setup.
       options:
         - '@sentry/browser'
-        - '@sentry/astro'        
+        - '@sentry/astro'
         - '@sentry/angular'
         - '@sentry/angular-ivy'
         - '@sentry/bun'
@@ -40,7 +40,6 @@ body:
         - '@sentry/gatsby'
         - '@sentry/nextjs'
         - '@sentry/node'
-        - '@sentry/opentelemetry-node'
         - '@sentry/react'
         - '@sentry/remix'
         - '@sentry/serverless'

.github/workflows/build.yml

@@ -49,7 +49,7 @@ env:
     ${{ github.workspace }}/packages/utils/esm
 
   BUILD_CACHE_KEY: build-cache-${{ github.event.inputs.commit || github.sha }}
-  BUILD_PROFILING_NODE_CACHE_TARBALL_KEY: profiling-node-tarball-${{ github.event.inputs.commit || github.sha }}
+  BUILD_CACHE_TARBALL_KEY: tarball-${{ github.event.inputs.commit || github.sha }}
 
   # GH will use the first restore-key it finds that matches
   # So it will start by looking for one from the same branch, else take the newest one it can find elsewhere
@@ -83,7 +83,7 @@ jobs:
           echo "COMMIT_MESSAGE=$(git log -n 1 --pretty=format:%s $COMMIT_SHA)" >> $GITHUB_ENV
 
       - name: Determine changed packages
-        uses: dorny/[email protected].0
+        uses: dorny/[email protected].1
         id: changed
         with:
           filters: |
@@ -402,15 +402,15 @@ jobs:
         uses: ./.github/actions/restore-cache
         env:
           DEPENDENCY_CACHE_KEY: ${{ needs.job_build.outputs.dependency_cache_key }}
-      - name: Pack tarballs
-        # Profiling tarball is built separately as we assemble the precompiled binaries
-        run: yarn build:tarball --ignore @sentry/profiling-node
 
-      - name: Restore profiling tarball
-        uses: actions/cache/restore@v4
+      - name: Extract Profiling Node Prebuilt Binaries
+        uses: actions/download-artifact@v3
         with:
-          key: ${{ env.BUILD_PROFILING_NODE_CACHE_TARBALL_KEY }}
-          path: ${{ github.workspace }}/packages/*/*.tgz
+          name: profiling-node-binaries-${{ github.sha }}
+          path: ${{ github.workspace }}/packages/profiling-node/lib/
+
+      - name: Pack tarballs
+        run: yarn build:tarball
 
       - name: Archive artifacts
         uses: actions/upload-artifact@v4
@@ -985,8 +985,6 @@ jobs:
           key: nx-Linux-${{ github.ref }}-${{ env.HEAD_COMMIT }}
           # On develop branch, we want to _store_ the cache (so it can be used by other branches), but never _restore_ from it
           restore-keys: ${{ env.NX_CACHE_RESTORE_KEYS }}
-      - name: Build tarballs
-        run: yarn build:tarball --ignore @sentry/profiling-node
 
       # Rebuild profiling by compiling TS and pull the precompiled binary artifacts
       - name: Build Profiling Node
@@ -1001,21 +999,22 @@ jobs:
         # https://github.com/actions/upload-artifact/issues/478
         if: |
           (needs.job_get_metadata.outputs.changed_profiling_node_bindings == 'true') ||
+            (needs.job_get_metadata.outputs.is_release == 'true') ||
           (github.event_name != 'pull_request')
         uses: actions/download-artifact@v3
         with:
           name: profiling-node-binaries-${{ github.sha }}
           path: ${{ github.workspace }}/packages/profiling-node/lib/
 
       - name: Build Profiling tarball
-        run: yarn build:tarball --scope @sentry/profiling-node
+        run: yarn build:tarball
       # End rebuild profiling
 
       - name: Stores tarballs in cache
         uses: actions/cache/save@v4
         with:
           path: ${{ github.workspace }}/packages/*/*.tgz
-          key: ${{ env.BUILD_PROFILING_NODE_CACHE_TARBALL_KEY }}
+          key: ${{ env.BUILD_CACHE_TARBALL_KEY }}
 
   job_e2e_tests:
     name: E2E ${{ matrix.label || matrix.test-application }} Test
@@ -1111,7 +1110,7 @@ jobs:
         uses: actions/cache/restore@v4
         with:
           path: ${{ github.workspace }}/packages/*/*.tgz
-          key: ${{ env.BUILD_PROFILING_NODE_CACHE_TARBALL_KEY }}
+          key: ${{ env.BUILD_CACHE_TARBALL_KEY }}
 
       - name: Get node version
         id: versions
@@ -1202,13 +1201,13 @@ jobs:
         with:
           name: profiling-node-binaries-${{ github.sha }}
           path: ${{ github.workspace }}/packages/profiling-node/lib/
-      - name: Build Profiling tarball
-        run: yarn build:tarball --scope @sentry/profiling-node
+
       - name: Restore tarball cache
         uses: actions/cache/restore@v4
         with:
           path: ${{ github.workspace }}/packages/*/*.tgz
-          key: ${{ env.BUILD_PROFILING_NODE_CACHE_TARBALL_KEY }}
+          key: ${{ env.BUILD_CACHE_TARBALL_KEY }}
+          fail-on-cache-miss : true
 
       - name: Get node version
         id: versions

.github/workflows/canary.yml

@@ -135,7 +135,7 @@ jobs:
 
       - name: Create Issue
         if: failure() && github.event_name == 'schedule'
-        uses: JasonEtco/create-an-issue@e27dddc79c92bc6e4562f268fffa5ed752639abd
+        uses: JasonEtco/create-an-issue@1b14a70e4d8dc185e5cc76d3bec9eab20257b2c5
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           RUN_LINK: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
@@ -176,7 +176,7 @@ jobs:
 
       - name: Create Issue
         if: failure() && github.event_name == 'schedule'
-        uses: JasonEtco/create-an-issue@e27dddc79c92bc6e4562f268fffa5ed752639abd
+        uses: JasonEtco/create-an-issue@1b14a70e4d8dc185e5cc76d3bec9eab20257b2c5
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           RUN_LINK: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}

.github/workflows/flaky-test-detector.yml

@@ -71,7 +71,7 @@ jobs:
         run: npx playwright install-deps
 
       - name: Determine changed tests
-        uses: dorny/[email protected].0
+        uses: dorny/[email protected].1
         id: changed
         with:
           list-files: json

.github/workflows/issue-package-label.yml

@@ -56,9 +56,6 @@ jobs:
               "@sentry.node": {
                 "label": "Package: Node"
               },
-              "@sentry.opentelemetry-node": {
-                "label": "Package: otel-node"
-              },
               "@sentry.react": {
                 "label": "Package: react"
               },

CHANGELOG.md

@@ -4,6 +4,39 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 8.0.0-alpha.2
+
+This alpha release fixes a build problem that prevented 8.0.0-alpha.1 from being properly released.
+
+### Important Changes
+
+- **feat: Remove `@sentry/opentelemetry-node` package (#10906)**
+
+The `@sentry/opentelemetry-node` package has been removed. Instead, you can either use `@sentry/node` with built-in
+OpenTelemetry support, or use `@sentry/opentelemetry` to manually connect Sentry with OpenTelemetry.
+
+### Removal/Refactoring of deprecated functionality
+
+- ref: Refactor some deprecated `startSpan` options (#10825)
+- feat(v8/core): remove void from transport return (#10794)
+- ref(integrations): Delete deprecated class integrations (#10887)
+
+### Other Changes
+
+- feat(core): Use serialized spans in transaction event (#10912)
+- feat(deps): bump @sentry/cli from 2.28.6 to 2.29.1 (#10908)
+- feat(node): Allow to configure `skipOpenTelemetrySetup` (#10907)
+- feat(esm): Import rather than require `inspector` (#10910)
+- fix(browser): Don't use chrome variable name (#10874)
+- chore(sveltekit): Fix punctuation in a console.log (#10895)
+- fix(opentelemetry): Ensure DSC propagation works correctly (#10904)
+- feat(browser): Exclude span exports from non-performance CDN bundles (#10879)
+- ref: Refactor span status handling to be OTEL compatible (#10871)
+- feat(core): Fix span scope handling & transaction setting (#10886)
+- ref(ember): Avoid namespace import to hopefully resolve minification issue (#10885)
+
+Work in this release contributed by @harish-talview & @bfontaine. Thank you for your contributions!
+
 ## 8.0.0-alpha.1
 
 This is the first Alpha release of the v8 cycle, which includes a variety of breaking changes.

MIGRATION.md

@@ -118,7 +118,7 @@ Sentry.init({
   tracesSampleRate: 1.0,
 });
 
-// Before (v8)
+// After (v8)
 const Sentry = require('@sentry/node');
 
 Sentry.init({
@@ -272,6 +272,7 @@ Removed top-level exports: `tracingOrigins`, `MetricsAggregator`, `metricsAggreg
 - [Removal of `spanStatusfromHttpCode` in favour of `getSpanStatusFromHttpCode`](./MIGRATION.md#removal-of-spanstatusfromhttpcode-in-favour-of-getspanstatusfromhttpcode)
 - [Removal of `addGlobalEventProcessor` in favour of `addEventProcessor`](./MIGRATION.md#removal-of-addglobaleventprocessor-in-favour-of-addeventprocessor)
 - [Removal of `lastEventId()` method](./MIGRATION.md#deprecate-lasteventid)
+- [Remove `void` from transport return types](./MIGRATION.md#remove-void-from-transport-return-types)
 
 #### Deprecation of `Hub` and `getCurrentHub()`
 
@@ -435,6 +436,23 @@ addEventProcessor(event => {
 
 The `lastEventId` function has been removed. See [below](./MIGRATION.md#deprecate-lasteventid) for more details.
 
+#### Remove `void` from transport return types
+
+The `send` method on the `Transport` interface now always requires a `TransportMakeRequestResponse` to be returned in
+the promise. This means that the `void` return type is no longer allowed.
+
+```ts
+// Before (v7)
+interface Transport {
+  send(event: Event): Promise<void | TransportMakeRequestResponse>;
+}
+
+// After (v8)
+interface Transport {
+  send(event: Event): Promise<TransportMakeRequestResponse>;
+}
+```
+
 ### Browser SDK (Browser, React, Vue, Angular, Ember, etc.)
 
 Removed top-level exports: `Offline`, `makeXHRTransport`, `BrowserTracing`

dev-packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/init.js

@@ -5,6 +5,6 @@ window.Sentry = Sentry;
 Sentry.init({
   dsn: 'https://[email protected]/1337',
   defaultIntegrations: false,
-  integrations: [new Sentry.Integrations.Breadcrumbs()],
+  integrations: [Sentry.breadcrumbsIntegration()],
   sampleRate: 1,
 });

dev-packages/browser-integration-tests/suites/integrations/Breadcrumbs/fetch/init.js

@@ -5,6 +5,6 @@ window.Sentry = Sentry;
 Sentry.init({
   dsn: 'https://[email protected]/1337',
   defaultIntegrations: false,
-  integrations: [new Sentry.Integrations.Breadcrumbs()],
+  integrations: [Sentry.breadcrumbsIntegration()],
   sampleRate: 1,
 });

dev-packages/browser-integration-tests/suites/integrations/Breadcrumbs/xhr/init.js

@@ -5,6 +5,6 @@ window.Sentry = Sentry;
 Sentry.init({
   dsn: 'https://[email protected]/1337',
   defaultIntegrations: false,
-  integrations: [new Sentry.Integrations.Breadcrumbs()],
+  integrations: [Sentry.breadcrumbsIntegration()],
   sampleRate: 1,
 });

dev-packages/browser-integration-tests/suites/manual-client/browser-context/init.js

@@ -1,23 +1,23 @@
 import {
-  Breadcrumbs,
   BrowserClient,
-  FunctionToString,
-  HttpContext,
   Hub,
-  InboundFilters,
-  LinkedErrors,
+  breadcrumbsIntegration,
   dedupeIntegration,
   defaultStackParser,
+  functionToStringIntegration,
+  httpContextIntegration,
+  inboundFiltersIntegration,
+  linkedErrorsIntegration,
   makeFetchTransport,
 } from '@sentry/browser';
 
 const integrations = [
-  new Breadcrumbs(),
-  new FunctionToString(),
+  breadcrumbsIntegration(),
+  functionToStringIntegration(),
   dedupeIntegration(),
-  new HttpContext(),
-  new InboundFilters(),
-  new LinkedErrors(),
+  httpContextIntegration(),
+  inboundFiltersIntegration(),
+  linkedErrorsIntegration(),
 ];
 
 const client = new BrowserClient({

dev-packages/browser-integration-tests/suites/public-api/startSpan/basic/test.ts

@@ -1,5 +1,5 @@
 import { expect } from '@playwright/test';
-import type { SerializedEvent } from '@sentry/types';
+import type { Event } from '@sentry/types';
 
 import { sentryTest } from '../../../../utils/fixtures';
 import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';
@@ -10,7 +10,7 @@ sentryTest('should send a transaction in an envelope', async ({ getLocalTestPath
   }
 
   const url = await getLocalTestPath({ testDir: __dirname });
-  const transaction = await getFirstSentryEnvelopeRequest<SerializedEvent>(page, url);
+  const transaction = await getFirstSentryEnvelopeRequest<Event>(page, url);
 
   expect(transaction.transaction).toBe('parent_span');
   expect(transaction.spans).toBeDefined();
@@ -22,7 +22,7 @@ sentryTest('should report finished spans as children of the root transaction', a
   }
 
   const url = await getLocalTestPath({ testDir: __dirname });
-  const transaction = await getFirstSentryEnvelopeRequest<SerializedEvent>(page, url);
+  const transaction = await getFirstSentryEnvelopeRequest<Event>(page, url);
 
   expect(transaction.spans).toHaveLength(1);
 

dev-packages/browser-integration-tests/suites/public-api/startTransaction/basic_usage/test.ts

@@ -1,5 +1,5 @@
 import { expect } from '@playwright/test';
-import type { SerializedEvent } from '@sentry/types';
+import type { Event } from '@sentry/types';
 
 import { sentryTest } from '../../../../utils/fixtures';
 import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';
@@ -10,7 +10,7 @@ sentryTest('should report a transaction in an envelope', async ({ getLocalTestPa
   }
 
   const url = await getLocalTestPath({ testDir: __dirname });
-  const transaction = await getFirstSentryEnvelopeRequest<SerializedEvent>(page, url);
+  const transaction = await getFirstSentryEnvelopeRequest<Event>(page, url);
 
   expect(transaction.transaction).toBe('root_span');
   expect(transaction.spans).toBeDefined();
@@ -22,7 +22,7 @@ sentryTest('should report finished spans as children of the root span', async ({
   }
 
   const url = await getLocalTestPath({ testDir: __dirname });
-  const transaction = await getFirstSentryEnvelopeRequest<SerializedEvent>(page, url);
+  const transaction = await getFirstSentryEnvelopeRequest<Event>(page, url);
 
   const rootSpanId = transaction?.contexts?.trace?.span_id;