-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
meta(changelog): Update changelog for v8.0.0-alpha.2 #10923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [dorny/paths-filter](https://github.com/dorny/paths-filter) from 3.0.0 to 3.0.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dorny/paths-filter/releases">dorny/paths-filter's releases</a>.</em></p> <blockquote> <h2>v3.0.1</h2> <h2>What's Changed</h2> <ul> <li>Compare base and ref when token is empty by <a href="https://github.com/frouioui"><code>@frouioui</code></a> in <a href="https://redirect.github.com/dorny/paths-filter/pull/133">dorny/paths-filter#133</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/frouioui"><code>@frouioui</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/paths-filter/pull/133">dorny/paths-filter#133</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/dorny/paths-filter/compare/v3...v3.0.1">https://github.com/dorny/paths-filter/compare/v3...v3.0.1</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/dorny/paths-filter/blob/master/CHANGELOG.md">dorny/paths-filter's changelog</a>.</em></p> <blockquote> <h2>v3.0.1</h2> <ul> <li><a href="https://redirect.github.com/dorny/paths-filter/pull/133">Compare base and ref when token is empty</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dorny/paths-filter/commit/ebc4d7e9ebcb0b1eb21480bb8f43113e996ac77a"><code>ebc4d7e</code></a> Update CHANGELOG for v3.0.1</li> <li><a href="https://github.com/dorny/paths-filter/commit/45f16f1875754d8424ea8a6a134c81fd56637525"><code>45f16f1</code></a> Merge pull request <a href="https://redirect.github.com/dorny/paths-filter/issues/133">#133</a> from frouioui/main</li> <li><a href="https://github.com/dorny/paths-filter/commit/5da0e4c086f427696edbc188de7cc487edc8befd"><code>5da0e4c</code></a> Merge branch 'master'</li> <li><a href="https://github.com/dorny/paths-filter/commit/1441771bbfdd59dcd748680ee64ebd8faab1a242"><code>1441771</code></a> Update README.md</li> <li><a href="https://github.com/dorny/paths-filter/commit/245527a2efa6022ee4d6d9769af3a255ecf926fd"><code>245527a</code></a> Merge remote-tracking branch 'upstream/master'</li> <li>See full diff in <a href="https://github.com/dorny/paths-filter/compare/v3.0.0...v3.0.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [JasonEtco/create-an-issue](https://github.com/jasonetco/create-an-issue) from 2.9.1 to 2.9.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/jasonetco/create-an-issue/releases">JasonEtco/create-an-issue's releases</a>.</em></p> <blockquote> <h2>v2.9.2</h2> <h2>What's Changed</h2> <ul> <li>readme: actions/checkout@ v2 -> v3 by <a href="https://github.com/IdiosApps"><code>@IdiosApps</code></a> in <a href="https://redirect.github.com/JasonEtco/create-an-issue/pull/147">JasonEtco/create-an-issue#147</a></li> <li>Update actions version in readme and workflow file by <a href="https://github.com/saerosV"><code>@saerosV</code></a> in <a href="https://redirect.github.com/JasonEtco/create-an-issue/pull/151">JasonEtco/create-an-issue#151</a></li> <li>Use node20 by <a href="https://github.com/parkerbxyz"><code>@parkerbxyz</code></a> in <a href="https://redirect.github.com/JasonEtco/create-an-issue/pull/176">JasonEtco/create-an-issue#176</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/IdiosApps"><code>@IdiosApps</code></a> made their first contribution in <a href="https://redirect.github.com/JasonEtco/create-an-issue/pull/147">JasonEtco/create-an-issue#147</a></li> <li><a href="https://github.com/saerosV"><code>@saerosV</code></a> made their first contribution in <a href="https://redirect.github.com/JasonEtco/create-an-issue/pull/151">JasonEtco/create-an-issue#151</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/JasonEtco/create-an-issue/compare/v2.9.1...v2.9.2">https://github.com/JasonEtco/create-an-issue/compare/v2.9.1...v2.9.2</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/JasonEtco/create-an-issue/commit/1b14a70e4d8dc185e5cc76d3bec9eab20257b2c5"><code>1b14a70</code></a> Automatic compilation</li> <li><a href="https://github.com/JasonEtco/create-an-issue/commit/56fdd2d6f960e970fa9d5ca3cf3884b6ba5af477"><code>56fdd2d</code></a> Merge pull request <a href="https://redirect.github.com/jasonetco/create-an-issue/issues/176">#176</a> from parkerbxyz/node20</li> <li><a href="https://github.com/JasonEtco/create-an-issue/commit/c92e5306fc8fa3855000f690503657b0f6789f99"><code>c92e530</code></a> <code>@tsconfig/node-lts</code> → <code>@tsconfig/recommended</code></li> <li><a href="https://github.com/JasonEtco/create-an-issue/commit/d2f7266772042d6aad30578a6a30bd235e42b348"><code>d2f7266</code></a> Update TSConfig to use node-lts</li> <li><a href="https://github.com/JasonEtco/create-an-issue/commit/d0732be86a720b3f6beaa033ff6824a21c8d96be"><code>d0732be</code></a> Update ci.yml to use node20</li> <li><a href="https://github.com/JasonEtco/create-an-issue/commit/c0e947f6a6a44c2a4d10a9a62e27c852bf388b88"><code>c0e947f</code></a> Update action.yml to use node20</li> <li><a href="https://github.com/JasonEtco/create-an-issue/commit/ee46187b30bc83f9ee4a11207701bff2cdcbab3f"><code>ee46187</code></a> Merge pull request <a href="https://redirect.github.com/jasonetco/create-an-issue/issues/151">#151</a> from saerosV/main</li> <li><a href="https://github.com/JasonEtco/create-an-issue/commit/6d783382d37dd4148f0b2cc096b22b2fe79f63fa"><code>6d78338</code></a> Update setup-node action version</li> <li><a href="https://github.com/JasonEtco/create-an-issue/commit/f6aae5d93f99a9716dff422450a023bb06baeb2f"><code>f6aae5d</code></a> Update Checkout action version</li> <li><a href="https://github.com/JasonEtco/create-an-issue/commit/bf328b8b5904712ca3b68b91a291e1aa6fd1f507"><code>bf328b8</code></a> Merge pull request <a href="https://redirect.github.com/jasonetco/create-an-issue/issues/147">#147</a> from IdiosApps/patch-1</li> <li>Additional commits viewable in <a href="https://github.com/jasonetco/create-an-issue/compare/e27dddc79c92bc6e4562f268fffa5ed752639abd...1b14a70e4d8dc185e5cc76d3bec9eab20257b2c5">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This does the following things: 1. Instead of setting `transaction` tag, we ensure to set the `transaction` on the event itself. 2. This also allows us to remove code that lead to other bugs, which is that we needed to fork the scope for `startInactiveSpan` just to get the correct transaction tag. 3. Add tests to ensure that the scope is correctly applied when using `startInactiveSpan` ## Background I initially implemented `startInactiveSpan` to fork the current scope & set the span on that to satisfy two things: 1. We do not want to set this span as active on the actual current scope 2. We needed a way to set the transaction tag on the span (if it was a transaction) in an event processor For 2., in order for `getActiveSpan()` to work in there I had to make the span active in the forked scope. This kind of worked, BUT I now noticed that this has the massive problem: ```js const scope = getCurrentScope(); const span = startInactiveSpan(...); scope.setTag(...); // <-- this will not be applied to the span! ``` So I went in and fixed this - and since we talked about not needing to set the `transaction` tag anyhow (instead, just set the `transaction` itself!), I figured I can fix these in one go.
Deletes `FunctionToString`, `Breadcrumbs`, `InboundFilters`and `LinkedErrors` ref #8844
…sts (#10897) Noticed we seem to have forgotten this, we can skip this there (this runs as browser unit test).
This aligns the schema for `span.setStatus()` with the OTEL span schema. Since we still rely, internally, that the status is a string, we now handle this by using the `message` on the status, if set, to send this. We can internally look at changing this, but this should be OK for now.
…10879) I figured we don't actually need to expor these (e.g. `startSpan`, etc.) in non-performance CDN bundles. We can think about providing shims for these, but honestly not so sure 🤔
This updates the propagation handling in OTEL to the following: 1. If there is an active (local) span, we always pick up propagation context/DSC data from it. 2. Else, we try to pick it from the current scope 3. If we can't find this (e.g. a detached otel context is used), we try to pick it from the remote span context 4. Finally, if that also fails, we have no DSC Closes #10899
Users can/should instead just use `@sentry/node`, or use `@sentry/opentelemetry` themselves. Closes #9843
resolves #6880 Using `const chrome = ...` or similar breaks certain setups based on their bundler config. This makes changes to browser code so that we never declare a variable named `chrome`. I tried setting up https://eslint.org/docs/latest/rules/id-denylist to enforce this, but this unfortunately also looks as types declarations (so `type K = { chrome: ... }` is problematic.
This does break support for custom builds of Node which have been built without inspector support. The only one that comes to mind is Vercel/pkg but this has recently been deprecated since Node v21 supports building single file executables. We may come back later and find a way to work around this but we cannot use async `import` with the current code, so we'll need to revisit this after we have a proper ESM build working! This also removes `local-variables-async.ts` since it's not used and async inspector requires a worker thread to work.
Also warn if there is an incomplete setup, to ensure users notice if stuff is breaking. I do this by just keeping a set of things that were created, which is not perfect but IMHO good enough to notify users if they forgot to setup a specific thing...
Bumps [@sentry/cli](https://github.com/getsentry/sentry-cli) from 2.28.6 to 2.29.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/getsentry/sentry-cli/releases"><code>@sentry/cli</code>'s releases</a>.</em></p> <blockquote> <h2>2.29.1</h2> <p>Updated version 2.29.0 changelog. No code changes.</p> <h2>2.29.0</h2> <h3>Source maps fixes</h3> <p>This release fixes the behavior of <code>sourcemaps inject</code> and <code>sourcemaps upload</code>. We now treat minified and non-minified source files the same way in both commands, which was always the desired behavior, and is also consistent with our JS bundler plugins.</p> <p><strong>Please be aware that from now on, <code>sourcemaps inject</code> will inject debug IDs into all JS source files at the path provided to the command.</strong> If you only wish for some of the files to have debug IDs injected, you need to modify the path(s) passed to <code>sourcemaps inject</code> or you need to use the <code>--ignore</code> or <code>--ignore-file</code> options to exclude the files you do not wish to inject the debug IDs into.</p> <p>In the <code>sourcemaps upload</code> command, we have eliminated the "Minified Scripts" section in the Source Maps Upload Report. Instead, these minified scripts will appear under "Scripts."</p> <h3>Auth token validation</h3> <p>Sentry CLI now validates that you have provided an auth token whenever you run a command that requires authentication to succeed. If you fail to provide an auth token when running such a command, the Sentry CLI will exit with an error message explaining that the auth token is required but missing.</p> <h3>Other fixes & improvements</h3> <ul> <li>fix(sourcemaps): Add <code>.cjs</code> and <code>.mjs</code> to default <code>sourcemaps upload</code> extensions (<a href="https://redirect.github.com/getsentry/sentry-cli/issues/1961">#1961</a>) by <a href="https://github.com/szokeasaurusrex"><code>@szokeasaurusrex</code></a></li> <li>fix(xcode): Only parse Plist when required during RN source maps upload (<a href="https://redirect.github.com/getsentry/sentry-cli/issues/1940">#1940</a>) by <a href="https://github.com/krystofwoldrich"><code>@krystofwoldrich</code></a></li> <li>fix(files): Fail when deleting all files fails with 404 error (<a href="https://redirect.github.com/getsentry/sentry-cli/issues/1949">#1949</a>) by <a href="https://github.com/szokeasaurusrex"><code>@szokeasaurusrex</code></a></li> <li>fix: support windows on arm via x64 binary (<a href="https://redirect.github.com/getsentry/sentry-cli/issues/1943">#1943</a>) by <a href="https://github.com/MarshallOfSound"><code>@MarshallOfSound</code></a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md"><code>@sentry/cli</code>'s changelog</a>.</em></p> <blockquote> <h2>2.29.1</h2> <p>Updated version 2.29.0 changelog. No code changes.</p> <h2>2.29.0</h2> <h3>Source maps fixes</h3> <p>This release fixes the behavior of <code>sourcemaps inject</code> and <code>sourcemaps upload</code>. We now treat minified and non-minified source files the same way in both commands, which was always the desired behavior, and is also consistent with our JS bundler plugins.</p> <p><strong>Please be aware that from now on, <code>sourcemaps inject</code> will inject debug IDs into all JS source files at the path provided to the command.</strong> If you only wish for some of the files to have debug IDs injected, you need to modify the path(s) passed to <code>sourcemaps inject</code> or you need to use the <code>--ignore</code> or <code>--ignore-file</code> options to exclude the files you do not wish to inject the debug IDs into.</p> <p>In the <code>sourcemaps upload</code> command, we have eliminated the "Minified Scripts" section in the Source Maps Upload Report. Instead, these minified scripts will appear under "Scripts."</p> <h3>Auth token validation</h3> <p>Sentry CLI now validates that you have provided an auth token whenever you run a command that requires authentication to succeed. If you fail to provide an auth token when running such a command, the Sentry CLI will exit with an error message explaining that the auth token is required but missing.</p> <h3>Other fixes & improvements</h3> <ul> <li>fix(sourcemaps): Add <code>.cjs</code> and <code>.mjs</code> to default <code>sourcemaps upload</code> extensions (<a href="https://redirect.github.com/getsentry/sentry-cli/issues/1961">#1961</a>) by <a href="https://github.com/szokeasaurusrex"><code>@szokeasaurusrex</code></a></li> <li>fix(xcode): Only parse Plist when required during RN source maps upload (<a href="https://redirect.github.com/getsentry/sentry-cli/issues/1940">#1940</a>) by <a href="https://github.com/krystofwoldrich"><code>@krystofwoldrich</code></a></li> <li>fix(files): Fail when deleting all files fails with 404 error (<a href="https://redirect.github.com/getsentry/sentry-cli/issues/1949">#1949</a>) by <a href="https://github.com/szokeasaurusrex"><code>@szokeasaurusrex</code></a></li> <li>fix: support windows on arm via x64 binary (<a href="https://redirect.github.com/getsentry/sentry-cli/issues/1943">#1943</a>) by <a href="https://github.com/MarshallOfSound"><code>@MarshallOfSound</code></a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/getsentry/sentry-cli/commit/7edd5f6ca0dc155caf41b25e82dad3730fd940db"><code>7edd5f6</code></a> Update CHANGELOG.md</li> <li><a href="https://github.com/getsentry/sentry-cli/commit/d765edd75695d1efb6f7766232e65062dec1bab1"><code>d765edd</code></a> release: 2.29.1</li> <li><a href="https://github.com/getsentry/sentry-cli/commit/7e76944c66bcc0c49b50ed401e97d441b9ae1580"><code>7e76944</code></a> docs: Update changelog (<a href="https://redirect.github.com/getsentry/sentry-cli/issues/1966">#1966</a>)</li> <li><a href="https://github.com/getsentry/sentry-cli/commit/cbbace15961443055a649cf4fb4e45aeedceb6f8"><code>cbbace1</code></a> Merge branch 'release/2.29.0'</li> <li><a href="https://github.com/getsentry/sentry-cli/commit/876c624105438872a8ef655af64a5eda339a7c96"><code>876c624</code></a> release: 2.29.0</li> <li><a href="https://github.com/getsentry/sentry-cli/commit/708f4575e91c758eec6e18a1758f7135475cdcd7"><code>708f457</code></a> fix(sourcemaps): Remove distinction between <code>Source</code> and <code>MinifiedSource</code> for...</li> <li><a href="https://github.com/getsentry/sentry-cli/commit/a1fb39aefbd682355e45d5a4c9e354a00d9cbf67"><code>a1fb39a</code></a> Add clarifying comment to RN sourcemaps upload test (<a href="https://redirect.github.com/getsentry/sentry-cli/issues/1965">#1965</a>)</li> <li><a href="https://github.com/getsentry/sentry-cli/commit/6bef09e51b5ae3a947a410ad2f2c05f288c863b3"><code>6bef09e</code></a> fix: Merge "Scripts" and "Minified Scripts" under sourcemaps upload report (#...</li> <li><a href="https://github.com/getsentry/sentry-cli/commit/5708458bbee53c0b0ce4726c95af50b848a55481"><code>5708458</code></a> fix(sourcemaps): Add <code>.cjs</code> and <code>.mjs</code> to default <code>sourcemaps upload</code> extensi...</li> <li><a href="https://github.com/getsentry/sentry-cli/commit/5657d867bcaa9d2f72ca249151704f941709587d"><code>5657d86</code></a> fix(xcode): Only parse Plist when required during RN source maps upload (<a href="https://redirect.github.com/getsentry/sentry-cli/issues/1940">#1940</a>)</li> <li>Additional commits viewable in <a href="https://github.com/getsentry/sentry-cli/compare/2.28.6...2.29.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @AbhiPrasad. [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…10909) Let's see if that fixes stuff...
Previously, we passed the span instance, which is a) tricky because it keeps references etc, and b) doesn't work with the new span schema anyhow (because nothing is readable off the spans). This also means we can get rid of the `SerializedEvent` again, as this is now just the regular `Event` again.
Use `Promise<TransportMakeRequestResponse>` instead of `Promise<void | TransportMakeRequestResponse>`. As a result, remove `__sentry__baseTransport__` field from transports.
Merge changelog changes back, so we can cut another release. Co-authored-by: Lukas Stracke <[email protected]>
size-limit report 📦
|
Lms24
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if it works now...