`request` not captured in `@sentry/aws-serverless` + express

[relm923]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/aws-serverless

SDK Version

8.37.1

Framework Version

AWS Lambda + Express 4.21.1

Link to Sentry event

https://patina-health.sentry.io/issues/5996169896?project=6044571

Reproduction Example/SDK Setup

import * as Sentry from '@sentry/aws-serverless';

Sentry.init({
  dsn: process.env.SENTRY_DSN,
  environment: 'development',
  integrations: [Sentry.expressIntegration()],
  tracesSampleRate: 1.0,
  profilesSampleRate: 1.0,
});

import * as Sentry from '@sentry/aws-serverless';
import express from 'express';
import serverless from 'serverless-http';

const app = express();

app.get('/debug-sentry', (req, res) => {
  throw new Error('My first Sentry error!');
});

Sentry.setupExpressErrorHandler(app);

export const handler = Sentry.wrapHandler(serverless(app));

Steps to Reproduce

Run the above code ideally deployed to AWS. Invoke with payload similar to:

{
  "headers": { "content-type": "application/json" },
  "httpMethod": "GET",
  "path": "/debug-sentry"
}

Error is reported to Sentry but the request information is not included

Expected Result

Sentry event should include the request information.

This worked correctly with the same setup on Sentry 7

Actual Result

Sentry event does include aws.cloudwatch.logs and aws.lambda but no request information

[chargome]

Hey @relm923, thanks for reaching out. integrations: [Sentry.expressIntegration()], is not needed anymore in v8, you can safely remove that. Theoretically the requestDataIntegration should be enabled by default and include your request data. So can you please remove the integrations field in your init call and if it still not works add debug: true and check the output?

The latest docs on express can be found here.

[relm923]

Hi @chargome removing integrations does not appear to enable Express

import * as Sentry from '@sentry/aws-serverless';

Sentry.init({
  debug: true,
  dsn: process.env.SENTRY_DSN,
  environment: 'development',
  tracesSampleRate: 1.0,
  profilesSampleRate: 1.0,
});

Sentry Logger [log]: Integration installed: InboundFilters
Sentry Logger [log]: Integration installed: FunctionToString
Sentry Logger [log]: Integration installed: LinkedErrors
Sentry Logger [log]: Integration installed: RequestData
Sentry Logger [log]: Integration installed: Console
Sentry Logger [log]: Integration installed: Http
Sentry Logger [log]: Integration installed: NodeFetch
Sentry Logger [log]: Integration installed: OnUncaughtException
Sentry Logger [log]: Integration installed: OnUnhandledRejection
Sentry Logger [log]: Integration installed: ContextLines
Sentry Logger [log]: Integration installed: LocalVariablesAsync
Sentry Logger [log]: Integration installed: Context
Sentry Logger [log]: Integration installed: ProcessAndThreadBreadcrumbs
Sentry Logger [log]: Integration installed: Modules
Sentry Logger [log]: Integration installed: Aws
Sentry Logger [log]: Integration installed: AwsLambda
Sentry Logger [log]: Running in CommonJS mode.

import * as Sentry from '@sentry/aws-serverless';

Sentry.init({
  debug: true,
  dsn: process.env.SENTRY_DSN,
  environment: 'development',
  integrations: [Sentry.expressIntegration()],
  tracesSampleRate: 1.0,
  profilesSampleRate: 1.0,
});

Sentry Logger [log]: Integration installed: InboundFilters
Sentry Logger [log]: Integration installed: FunctionToString
Sentry Logger [log]: Integration installed: LinkedErrors
Sentry Logger [log]: Integration installed: RequestData
Sentry Logger [log]: Integration installed: Console
Sentry Logger [log]: Integration installed: Http
Sentry Logger [log]: Integration installed: NodeFetch
Sentry Logger [log]: Integration installed: OnUncaughtException
Sentry Logger [log]: Integration installed: OnUnhandledRejection
Sentry Logger [log]: Integration installed: ContextLines
Sentry Logger [log]: Integration installed: LocalVariablesAsync
Sentry Logger [log]: Integration installed: Context
Sentry Logger [log]: Integration installed: ProcessAndThreadBreadcrumbs
Sentry Logger [log]: Integration installed: Modules
Sentry Logger [log]: Integration installed: Aws
Sentry Logger [log]: Integration installed: AwsLambda
Sentry Logger [log]: Integration installed: Express
Sentry Logger [log]: Running in CommonJS mode.

[chargome]

You won't need this integration since it gets auto-instrumented out of the box. Does the setup work like this?

[relm923]

It does not work. Without the integrations param this appears in the logs

[Sentry] express is not instrumented. This is likely because you required/imported express before calling `Sentry.init()`.

Looking at the code it looks like aws-serverless not auto-instrument performance/tracing integrations

sentry-javascript/packages/aws-serverless/src/sdk.ts

Line 69 in 0aa7f1d

return [...getDefaultIntegrationsWithoutPerformance(), awsIntegration(), awsLambdaIntegration()];

https://github.com/getsentry/sentry-javascript/blob/develop/packages/node/src/sdk/index.ts#L57