Skip to content

Deprecate or Change type of exported wrap function #8897

Closed
@Lms24

Description

@Lms24

Problem Statement

TIL: In the browser SDK, we export a wrap function that people can wrap around any function call.

It'll try/catch whatever happens inside and report an error to Sentry (using our internal wrap function). This function is typed with any.

export function wrap(fn: (...args: any) => any): any {
return internalWrap(fn)();
}

Solution Brainstorm

We should rewrite the type here to use generics:

export function wrap<F>(fn: () => F): F

We can now add the newly typed function and deprecate the any-typed one to remove in v8

Alternative

Deprecate the function and remove it? I never saw this before and afaict it's not documented anywhere.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions