Skip to content

feat(core): Add span.isRecording() instead of span.sampled #10034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 5, 2024
Merged

feat(core): Add span.isRecording() instead of span.sampled #10034

merged 4 commits into from
Jan 5, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 3, 2024

To align this with OTEL API.

@mydea mydea requested review from lforst, Lms24 and AbhiPrasad January 3, 2024 11:13
@mydea mydea self-assigned this Jan 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 76.14 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 67.52 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 61.15 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.13 KB (+0.08% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.49 KB (0%)
@sentry/browser - Webpack (gzipped) 22.21 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 73.59 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 65.23 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 31.42 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.36 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 204.48 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 94.37 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 69.23 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 34.39 KB (+0.06% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.93 KB (+0.04% 🔺)
@sentry/react - Webpack (gzipped) 22.23 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 84.6 KB (+0.04% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.19 KB (+0.05% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 16.73 KB (0%)

@mydea mydea force-pushed the fn/spanIsRecording branch from b4c1c9f to 6f66c73 Compare January 5, 2024 08:12
@mydea mydea force-pushed the fn/spanIsRecording branch from ddbd371 to b50642a Compare January 5, 2024 10:18
@mydea mydea merged commit 644d697 into develop Jan 5, 2024
@mydea mydea deleted the fn/spanIsRecording branch January 5, 2024 12:03
c298lee pushed a commit that referenced this pull request Jan 9, 2024
@mydea @c298lee
feat(core): Add span.isRecording() instead of span.sampled (#10034)
3a45d86 
To align this with OTEL API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @Lms24 @AbhiPrasad