Skip to content

feat(core): Deprecate Span.origin in favor of sentry.origin attribute #10260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 19, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 19, 2024

This PR deprecates the Span.origin field on the class and the interface. It will be replaced in v8 by the semantic sentry.op attribute .

For now, I didn't yet deprecate SpanContext.origin but I think we could do it quite easily by just setting the origin in attributes when starting spans. Happy to tackle in a follow-up PR if we want to do this.

ref #10184

Copy link
Contributor

github-actions bot commented Jan 19, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.69 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.95 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.84 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.58 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.96 KB (+0.07% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.18 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.19 KB (0%)
@sentry/browser - Webpack (gzipped) 22.53 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.26 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.9 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.73 KB (+0.06% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.25 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.77 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 98.75 KB (+0.13% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.58 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.81 KB (+0.11% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.35 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped) 22.58 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.97 KB (+0.03% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.25 KB (+0.06% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.14 KB (0%)

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense, and probably I agree we can also remove it from StartSpanOptions!

@Lms24
Copy link
Member Author

Lms24 commented Jan 19, 2024

heads-up (cc @mydea since you already reviewed): Similarly to sentry.op, sentry.origin is now also added to the serialized event payload in span data.

@Lms24 Lms24 force-pushed the lms/feat-core-deprecate-span-origin branch from 9e21e01 to 500c3ed Compare January 19, 2024 13:44
@Lms24 Lms24 merged commit 1cceeae into develop Jan 19, 2024
@Lms24 Lms24 deleted the lms/feat-core-deprecate-span-origin branch January 19, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants