fix(core): Make FunctionToString integration use SETUP_CLIENTS weakmap
#10358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
mydea,
a team and
stephanie-anderson
and removed request for
a team
mydea
reviewed
Jan 25, 2024
| const _functionToStringIntegration = (() => { | ||
| return { | ||
| name: INTEGRATION_NAME, | ||
| setupOnce() { | ||
| if (hasSetup) { |
There was a problem hiding this comment.
do we need this? Should this not be done by setupOnce anyhow? 🤔
There was a problem hiding this comment.
ah, that's for the try-catch stuff I guess?
There was a problem hiding this comment.
do we need this? Should this not be done by setupOnce anyhow? 🤔
Actually you're right it should be taken care of by setupOnce. I'll remove.
mydea
approved these changes
Jan 25, 2024
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditing our integrations to make sure they work with the new client paradigm, also adding
export typewhere appropriate.