Skip to content

test(ci): Do not run browser integration tests for CJS #10423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 30, 2024

This does not really tell us anything the ESM tests do not already tell us. We can save some CI time there...

@mydea mydea requested review from lforst, Lms24 and AbhiPrasad January 30, 2024 14:52
@mydea mydea self-assigned this Jan 30, 2024
@mydea mydea marked this pull request as ready for review January 30, 2024 14:52
This does not really tell us anything the ESM tests do not already tell us.
@mydea mydea force-pushed the fn/drop-cjs-browser-tests branch from 34e1fa5 to 753d7a6 Compare January 30, 2024 14:53
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.18 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.39 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.28 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.01 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.41 KB (+0.03% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.28 KB (+0.05% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (0%)
@sentry/browser - Webpack (gzipped) 22.6 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.54 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.45 KB (+0.13% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.66 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.12 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.13 KB (+0.14% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.56 KB (+0.11% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.78 KB (-0.02% 🔽)
@sentry/react - Webpack (gzipped) 22.63 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.45 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.76 KB (+0.01% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@mydea mydea merged commit 20d11cd into develop Jan 30, 2024
@mydea mydea deleted the fn/drop-cjs-browser-tests branch January 30, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants