feat(core): Streamline custom hub creation for node-experimental #10555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an intermediate step to streamline what we need to customize in OTEL. This should make it easier to slowly remove customizations there. The main change is that you can set a `createHub` method on the main carrier, which will be used if set. This way, all the code we have to duplicate in node-experimental right now just to create the correct `OpenTelemetryHub` can mostly go away. We will remove this again during then v8 cycle.
size-limit report 📦
|
AbhiPrasad
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an intermediate step to streamline what we need to customize in OTEL. This should make it easier to slowly remove customizations there.
The main change is that you can set a
createHubmethod on the main carrier, which will be used if set. This way, all the code we have to duplicate in node-experimental right now just to create the correctOpenTelemetryHubcan mostly go away.We will remove this again during then v8 cycle.