-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(v8/serverless): Use subpath exports package #10561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
".": { | ||
"import": { | ||
"default": "./build/npm/esm/index.js", | ||
"types": "./build/npm/types/index.d.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future this will be *.mjs
fwiw
package: '@sentry/serverless', | ||
package: '@sentry/serverless/aws', | ||
exports: Object.keys(SentryServerless), | ||
ignoreExports: ['cron', 'hapiErrorPlugin', 'enableAnrDetection'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add another e2e test to validate the subpath exports if we are fine with this approach.
I don't have a strong opinion, but I think I tend to say let's maybe just make these dedicated packages. As logically otherwise e.g. react/vue/svelte could also just be subpath exports from browser 🤔 But maybe serverless is also simply "less important" and it's good enough this way - not sure. |
I am with Francesco on this one. No hard opinions but dedicated packages would make a bit more sense to me. |
This is a direct follow up to #10540, where I refactored the serverless package to use subpath exports.
Does this API feel reasonable to you? Should we go a step further and just publish separate packages?