Skip to content

ref: Remove lastEventId #10585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/astro/src/index.server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ export {
defaultIntegrations,
getDefaultIntegrations,
defaultStackParser,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
flush,
close,
getSentryRelease,
Expand Down
5 changes: 0 additions & 5 deletions packages/astro/src/index.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,4 @@ export declare const defaultStackParser: StackParser;
export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
* @deprecated This function will be removed in the next major version of the Sentry SDK.
*/
export declare function lastEventId(): string | undefined;

export default sentryAstro;
2 changes: 0 additions & 2 deletions packages/browser/src/exports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ export {
getCurrentScope,
Hub,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
// eslint-disable-next-line deprecation/deprecation
// eslint-disable-next-line deprecation/deprecation
makeMain,
setCurrentClient,
Expand Down
7 changes: 0 additions & 7 deletions packages/browser/src/sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,13 +198,6 @@ export const showReportDialog: ShowReportDialogFunction = (
};
}

// TODO(v8): Remove this entire if statement. `eventId` will be a required option.
// eslint-disable-next-line deprecation/deprecation
if (!options.eventId) {
// eslint-disable-next-line deprecation/deprecation
options.eventId = hub.lastEventId();
}

const script = WINDOW.document.createElement('script');
script.async = true;
script.crossOrigin = 'anonymous';
Expand Down
2 changes: 0 additions & 2 deletions packages/bun/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ export {
getIsolationScope,
Hub,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
// eslint-disable-next-line deprecation/deprecation
makeMain,
setCurrentClient,
runWithAsyncContext,
Expand Down
11 changes: 0 additions & 11 deletions packages/core/src/exports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -370,17 +370,6 @@ export async function close(timeout?: number): Promise<boolean> {
return Promise.resolve(false);
}

/**
* This is the getter for lastEventId.
*
* @returns The last event id of a captured event.
* @deprecated This function will be removed in the next major version of the Sentry SDK.
*/
export function lastEventId(): string | undefined {
// eslint-disable-next-line deprecation/deprecation
return getCurrentHub().lastEventId();
}

/**
* Get the currently active client.
*/
Expand Down
19 changes: 2 additions & 17 deletions packages/core/src/hub.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,6 @@ export class Hub implements HubInterface {
/** Is a {@link Layer}[] containing the client and scope */
private readonly _stack: Layer[];

/** Contains the last event id of a captured event. */
private _lastEventId?: string;

private _isolationScope: Scope;

/**
Expand Down Expand Up @@ -354,7 +351,7 @@ export class Hub implements HubInterface {
* @deprecated Use `Sentry.captureException()` instead.
*/
public captureException(exception: unknown, hint?: EventHint): string {
const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
const eventId = hint && hint.event_id ? hint.event_id : uuid4();
const syntheticException = new Error('Sentry syntheticException');
// eslint-disable-next-line deprecation/deprecation
this.getScope().captureException(exception, {
Expand All @@ -373,7 +370,7 @@ export class Hub implements HubInterface {
* @deprecated Use `Sentry.captureMessage()` instead.
*/
public captureMessage(message: string, level?: SeverityLevel, hint?: EventHint): string {
const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
const eventId = hint && hint.event_id ? hint.event_id : uuid4();
const syntheticException = new Error(message);
// eslint-disable-next-line deprecation/deprecation
this.getScope().captureMessage(message, level, {
Expand All @@ -393,23 +390,11 @@ export class Hub implements HubInterface {
*/
public captureEvent(event: Event, hint?: EventHint): string {
const eventId = hint && hint.event_id ? hint.event_id : uuid4();
if (!event.type) {
this._lastEventId = eventId;
}
// eslint-disable-next-line deprecation/deprecation
this.getScope().captureEvent(event, { ...hint, event_id: eventId });
return eventId;
}

/**
* @inheritDoc
*
* @deprecated This will be removed in v8.
*/
public lastEventId(): string | undefined {
return this._lastEventId;
}

/**
* @inheritDoc
*
Expand Down
2 changes: 0 additions & 2 deletions packages/core/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ export {
configureScope,
flush,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
// eslint-disable-next-line deprecation/deprecation
startTransaction,
setContext,
setExtra,
Expand Down
2 changes: 0 additions & 2 deletions packages/deno/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ export {
getIsolationScope,
Hub,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
// eslint-disable-next-line deprecation/deprecation
makeMain,
setCurrentClient,
runWithAsyncContext,
Expand Down
2 changes: 0 additions & 2 deletions packages/node-experimental/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ export {
captureMessage,
addGlobalEventProcessor,
addEventProcessor,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
setContext,
setExtra,
setExtras,
Expand Down
9 changes: 0 additions & 9 deletions packages/node-experimental/src/sdk/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,6 @@ export function withIsolationScope<T>(callback: (isolationScope: Scope) => T): T
});
}

/**
* Get the ID of the last sent error event.
* @deprecated This function will be removed in the next major version of the Sentry SDK.
*/
export function lastEventId(): string | undefined {
// eslint-disable-next-line deprecation/deprecation
return getCurrentScope().lastEventId();
}

/**
* Configure the current scope.
* @deprecated Use `getCurrentScope()` instead.
Expand Down
2 changes: 0 additions & 2 deletions packages/node-experimental/src/sdk/hub.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
configureScope,
getClient,
getCurrentScope,
lastEventId,
setContext,
setExtra,
setExtras,
Expand Down Expand Up @@ -71,7 +70,6 @@ export function getCurrentHub(): Hub {
return getCurrentScope().captureMessage(message, level, hint);
},
captureEvent,
lastEventId,
addBreadcrumb,
setUser,
setTags,
Expand Down
14 changes: 0 additions & 14 deletions packages/node-experimental/src/sdk/scope.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ export function isInitialized(): boolean {
export class Scope extends OpenTelemetryScope implements ScopeInterface {
protected _client: Client | undefined;

protected _lastEventId: string | undefined;

/**
* @inheritDoc
*/
Expand Down Expand Up @@ -131,8 +129,6 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
this,
);

this._lastEventId = eventId;

return eventId;
}

Expand All @@ -153,28 +149,18 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
this,
);

this._lastEventId = eventId;

return eventId;
}

/** Capture a message for this scope. */
public captureEvent(event: Event, hint?: EventHint): string {
const eventId = hint && hint.event_id ? hint.event_id : uuid4();
if (!event.type) {
this._lastEventId = eventId;
}

getClient().captureEvent(event, { ...hint, event_id: eventId }, this);

return eventId;
}

/** Get the ID of the last sent error event. */
public lastEventId(): string | undefined {
return this._lastEventId;
}

/**
* @inheritDoc
*/
Expand Down
4 changes: 0 additions & 4 deletions packages/node-experimental/src/sdk/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ export interface ScopeData {
export interface Scope extends BaseScope {
// @ts-expect-error typeof this is what we want here
clone(scope?: Scope): typeof this;
/**
* @deprecated This function will be removed in the next major version of the Sentry SDK.
*/
lastEventId(): string | undefined;
getScopeData(): ScopeData;
}

Expand Down
2 changes: 0 additions & 2 deletions packages/node/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ export {
getIsolationScope,
Hub,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
// eslint-disable-next-line deprecation/deprecation
makeMain,
setCurrentClient,
runWithAsyncContext,
Expand Down
3 changes: 1 addition & 2 deletions packages/react/src/errorboundary.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ class ErrorBoundary extends React.Component<ErrorBoundaryProps, ErrorBoundarySta
if (client && client.on && props.showDialog) {
this._openFallbackReportDialog = false;
client.on('afterSendEvent', event => {
if (!event.type && event.event_id === this._lastEventId) {
// eslint-disable-next-line deprecation/deprecation
if (!event.type && this._lastEventId && event.event_id === this._lastEventId) {
showReportDialog({ ...props.dialogOptions, eventId: this._lastEventId });
}
});
Expand Down
2 changes: 0 additions & 2 deletions packages/remix/src/index.server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ export {
defaultIntegrations,
getDefaultIntegrations,
defaultStackParser,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
flush,
close,
getSentryRelease,
Expand Down
6 changes: 0 additions & 6 deletions packages/remix/src/index.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,3 @@ declare const runtime: 'client' | 'server';

export const close = runtime === 'client' ? clientSdk.close : serverSdk.close;
export const flush = runtime === 'client' ? clientSdk.flush : serverSdk.flush;

/**
* @deprecated This function will be removed in the next major version of the Sentry SDK.
*/
// eslint-disable-next-line deprecation/deprecation
export const lastEventId = runtime === 'client' ? clientSdk.lastEventId : serverSdk.lastEventId;
2 changes: 0 additions & 2 deletions packages/serverless/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ export {
flush,
getSentryRelease,
init,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
DEFAULT_USER_INCLUDES,
addRequestDataToEvent,
extractRequestData,
Expand Down
5 changes: 0 additions & 5 deletions packages/sveltekit/src/index.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,3 @@ export declare const defaultStackParser: StackParser;

export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
* @deprecated This function will be removed in the next major version of the Sentry SDK.
*/
export declare function lastEventId(): string | undefined;
2 changes: 0 additions & 2 deletions packages/sveltekit/src/server/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ export {
defaultIntegrations,
getDefaultIntegrations,
defaultStackParser,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
flush,
close,
getSentryRelease,
Expand Down
9 changes: 0 additions & 9 deletions packages/types/src/hub.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,6 @@ export interface Hub {
*/
captureEvent(event: Event, hint?: EventHint): string;

/**
* This is the getter for lastEventId.
*
* @returns The last event id of a captured event.
*
* @deprecated This will be removed in v8.
*/
lastEventId(): string | undefined;

/**
* Records a new breadcrumb which will be attached to future events.
*
Expand Down
2 changes: 0 additions & 2 deletions packages/vercel-edge/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ export {
getIsolationScope,
Hub,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
// eslint-disable-next-line deprecation/deprecation
makeMain,
setCurrentClient,
runWithAsyncContext,
Expand Down