Skip to content

ref(core): Make on and emit required on client #10603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 12, 2024

This allows us to remove a bunch of code around fallbacks etc. Esp. in replay this also allows us to remove a bunch of code around breadcrumbs etc.

note @JonasBa I did not remove this in profiling-node yet because the test rely on this quite a bunch, can you take a look at this when you've got some time?

@mydea mydea self-assigned this Feb 12, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally 🚀

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.86 KB (-0.39% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.09 KB (-0.41% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.02 KB (-0.41% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.72 KB (-0.47% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.25 KB (-0.32% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.1 KB (-0.36% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.13 KB (-0.21% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.13 KB (-0.25% 🔽)
@sentry/browser - Webpack (gzipped) 22.39 KB (-0.4% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.87 KB (-0.43% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.4 KB (-0.46% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.34 KB (-0.4% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.45 KB (-0.47% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.42 KB (-0.59% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.97 KB (-0.5% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.38 KB (-0.65% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.52 KB (-0.33% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.47 KB (-0.43% 🔽)
@sentry/react - Webpack (gzipped) 22.44 KB (-0.36% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.21 KB (-0.37% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.32 KB (-0.21% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.11 KB (-0.55% 🔽)

@mydea mydea merged commit cb6912a into develop Feb 12, 2024
@mydea mydea deleted the fn/client-hooks branch February 12, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants