Skip to content

docs: Fix deprecation message for span data/attributes #10604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 12, 2024

This was apparently left over from some in-between state, users should actually use spanToJSON(span) there to get attributes.

@mydea mydea self-assigned this Feb 12, 2024
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.09 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.29 KB (-0.12% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.23 KB (-0.12% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.93 KB (-0.13% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.27 KB (-0.25% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.13 KB (-0.25% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.15 KB (-0.15% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.15 KB (-0.19% 🔽)
@sentry/browser - Webpack (gzipped) 22.4 KB (-0.35% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.06 KB (-0.17% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.59 KB (-0.18% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.37 KB (-0.32% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.46 KB (-0.41% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.21 KB (-0.22% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.03 KB (-0.44% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.42 KB (-0.6% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.54 KB (-0.28% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.68 KB (-0.13% 🔽)
@sentry/react - Webpack (gzipped) 22.45 KB (-0.3% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.43 KB (-0.13% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.35 KB (-0.14% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.12 KB (-0.48% 🔽)

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@mydea mydea merged commit 31faca3 into develop Feb 12, 2024
@mydea mydea deleted the fn/fix-deprecation-message branch February 12, 2024 12:16
mydea added a commit that referenced this pull request Feb 12, 2024
This was apparently left over from some in-between state, users should
actually use `spanToJSON(span)` there to get attributes.
mydea added a commit that referenced this pull request Feb 12, 2024
This was apparently left over from some in-between state, users should
actually use `spanToJSON(span)` there to get attributes.

Backporting this (#10604 ) to v7!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants