Skip to content

feat(v8/astro): Remove deprecated exports from Astro SDK #10611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions packages/astro/src/index.server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ import { handleRequest } from './server/middleware';

// Hence, we export everything from the Node SDK explicitly:
export {
// eslint-disable-next-line deprecation/deprecation
addGlobalEventProcessor,
addEventProcessor,
addBreadcrumb,
captureException,
Expand All @@ -18,10 +16,6 @@ export {
captureCheckIn,
withMonitor,
createTransport,
// eslint-disable-next-line deprecation/deprecation
extractTraceparentData,
// eslint-disable-next-line deprecation/deprecation
getActiveTransaction,
getHubFromCarrier,
// eslint-disable-next-line deprecation/deprecation
getCurrentHub,
Expand All @@ -31,12 +25,8 @@ export {
getGlobalScope,
getIsolationScope,
Hub,
// eslint-disable-next-line deprecation/deprecation
makeMain,
setCurrentClient,
Scope,
// eslint-disable-next-line deprecation/deprecation
startTransaction,
SDK_VERSION,
setContext,
setExtra,
Expand All @@ -46,14 +36,10 @@ export {
setUser,
getSpanStatusFromHttpCode,
setHttpStatus,
// eslint-disable-next-line deprecation/deprecation
trace,
withScope,
withIsolationScope,
autoDiscoverNodePerformanceMonitoringIntegrations,
makeNodeTransport,
// eslint-disable-next-line deprecation/deprecation
defaultIntegrations,
getDefaultIntegrations,
defaultStackParser,
flush,
Expand All @@ -78,8 +64,6 @@ export {
setMeasurement,
getActiveSpan,
startSpan,
// eslint-disable-next-line deprecation/deprecation
startActiveSpan,
startInactiveSpan,
startSpanManual,
continueTrace,
Expand Down
8 changes: 4 additions & 4 deletions packages/astro/src/index.types.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// We export everything from both the client part of the SDK and from the server part.
// Some of the exports collide, which is not allowed, unless we redifine the colliding
// Some of the exports collide, which is not allowed, unless we redefine the colliding
// exports in this file - which we do below.
export * from './index.client';
export * from './index.server';
Expand All @@ -13,9 +13,9 @@ import sentryAstro from './index.server';
/** Initializes Sentry Astro SDK */
export declare function init(options: Options | clientSdk.BrowserOptions | serverSdk.NodeOptions): void;

// We export a merged Integrations object so that users can (at least typing-wise) use all integrations everywhere.
// eslint-disable-next-line deprecation/deprecation
export declare const Integrations: typeof clientSdk.Integrations & typeof serverSdk.Integrations;
// We only export server Integrations for now, until the exports are removed from Svelte and Node SDKs.
// Necessary to avoid type collision.
export declare const Integrations: typeof serverSdk.Integrations;

export declare const linkedErrorsIntegration: typeof clientSdk.linkedErrorsIntegration;

Expand Down