Skip to content

test(astro): Remove old BrowserTracing test #10622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 12, 2024

Spotted one more deprecation ignore in Astro (after #10611) where I initially thought there's more logic to consider but turns out it's just the test that's no longer necessary in a v8 world.

@Lms24 Lms24 requested review from mydea and AbhiPrasad February 12, 2024 16:01
@@ -8,7 +8,7 @@ import {
import { applySdkMetadata, hasTracingEnabled } from '@sentry/core';
import type { Integration } from '@sentry/types';

// Treeshakable guard to remove all code related to tracing
// Tree-shakable guard to remove all code related to tracing
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just random typo fix

Copy link
Contributor

github-actions bot commented Feb 12, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.82 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.06 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.98 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.67 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.25 KB (-0.01% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.15 KB (-0.01% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.16 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (-0.01% 🔽)
@sentry/browser - Webpack (gzipped) 22.43 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.1 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.61 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.58 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.69 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.81 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.43 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.95 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.82 KB (-0.01% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.43 KB (-0.01% 🔽)
@sentry/react - Webpack (gzipped) 22.45 KB (-0.01% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.09 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.35 KB (-0.01% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.12 KB (-0.01% 🔽)

@Lms24 Lms24 enabled auto-merge (squash) February 13, 2024 17:29
@Lms24 Lms24 merged commit 5ec402d into develop Feb 13, 2024
@Lms24 Lms24 deleted the lms/test-astro-remove-test branch February 13, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants