Skip to content

chore(ci): Ensure "Build & Test" workflow runs on v7 #10671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 15, 2024

Noticed our "Build & Test" workflow doesn't run on v7 which caused failing tests on the v7 branch, blocking a release. This PR adds v7 to one of the branches where the workflow is running.

Furthermore:

  • adjusted the is_develop variable to also be true for v7
  • size check to compare against v7

I think these additional changes make sense but happy to revert if reviewers have concerns

@Lms24 Lms24 changed the base branch from develop to v7 February 15, 2024 08:06
@Lms24 Lms24 marked this pull request as ready for review February 15, 2024 08:11
Copy link
Contributor

github-actions bot commented Feb 15, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.42 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.65 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.58 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.26 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.6 KB (added)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.48 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.37 KB (added)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.38 KB (added)
@sentry/browser - Webpack (gzipped) 22.64 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.69 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 68.18 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 34.01 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped) 25 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 214.8 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 102.6 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.89 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 37.14 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 70.01 KB (added)
@sentry/react - Webpack (gzipped) 22.67 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.68 KB (added)
@sentry/nextjs Client - Webpack (gzipped) 51.87 KB (added)
@sentry-internal/feedback - Webpack (gzipped) 17.22 KB (added)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants