Ryan953/feedback async

[ryan953]

This is building off a version of #10590, specifically working towards async loading of the Dialog component, and rewriting it in preact in order to host and interact with the screenshot feature in an easier way.

Setup in my test app is (gives screenshots):

import { feedback2Integration, feedback2ModalIntegration, feedback2ScreenshotIntegration } from "@sentry-internal/feedback2";


  integrations: [
    feedback2Integration({
      colorScheme: 'light',
      isNameRequired: false,
      isEmailRequired: false,
    }),
    feedback2ModalIntegration(),
    feedback2ScreenshotIntegration(),
  ]

[github-actions]

size-limit report 📦

Path	Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)	84.03 KB (+8.75% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)	69.03 KB (+0.72% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped)	72.96 KB (+0.71% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)	62.54 KB (+0.8% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped)	33.25 KB (+1.62% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)	33.14 KB (+1.3% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped)	37.34 KB (+20.79% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped)	37.33 KB (+20.75% 🔺)
@sentry/browser - Webpack (gzipped)	22.41 KB (+0.99% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)	82.05 KB (+8.32% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)	67.52 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)	33.48 KB (+0.58% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped)	24.69 KB (-0.15% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)	212.25 KB (+0.47% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)	100.97 KB (+0.98% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)	73.87 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)	36.78 KB (+1.17% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)	69.33 KB (+0.75% 🔺)
@sentry/react - Webpack (gzipped)	22.44 KB (+0.99% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)	86.81 KB (+1.84% 🔺)
@sentry/nextjs Client - Webpack (gzipped)	50.05 KB (+0.79% 🔺)
@sentry-internal/feedback - Webpack (gzipped)	23.47 KB (+36.94% 🔺)

[c298lee]

Does this work properly when you press cancel on the prompt to allow it to see the tab?

[ryan953]

good question, and no it doesn't!

[c298lee]

[ryan953]

handled it!

it's just passing the message along to the user, which won't always be the best. In the future we can get inside that takeScreenshot().catch(...) call and rewrite messages as needed.